Skip to content

feat(storage): support Bucket custom placement config #9481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coryan merged 2 commits into from
Jul 14, 2022
Merged

feat(storage): support Bucket custom placement config #9481

coryan merged 2 commits into from
Jul 14, 2022

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Jul 14, 2022 •
edited
Loading

Fixes #9135

This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jul 14, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

google-cloud-cpp-bot commented Jul 14, 2022

Google Cloud Build Logs
For commit: c7c8e77a5bb6657f37b301450d01e6b3c8cca6b5

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jul 14, 2022 •
edited
Loading

Codecov Report

Merging #9481 (bee617e) into main (3753156) will increase coverage by 0.00%.
The diff coverage is 94.82%.

@@           Coverage Diff            @@
##             main    #9481    +/-   ##
========================================
  Coverage   94.64%   94.64%            
========================================
  Files        1485     1485            
  Lines      136864   136977   +113     
========================================
+ Hits       129530   129640   +110     
- Misses       7334     7337     +3
Impacted Files Coverage Δ
google/cloud/storage/bucket_metadata.cc 98.24% <71.42%> (-0.57%) ⬇️
...ud/storage/internal/grpc_bucket_metadata_parser.cc 92.30% <87.50%> (-0.25%) ⬇️
...e/cloud/storage/internal/bucket_metadata_parser.cc 98.03% <92.00%> (-0.40%) ⬇️
google/cloud/storage/bucket_metadata.h 99.00% <100.00%> (+0.07%) ⬆️
google/cloud/storage/bucket_metadata_test.cc 99.41% <100.00%> (+0.02%) ⬆️
...e/cloud/storage/examples/storage_bucket_samples.cc 93.86% <100.00%> (+0.01%) ⬆️
...orage/internal/grpc_bucket_metadata_parser_test.cc 99.42% <100.00%> (+0.03%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 97.98% <0.00%> (-0.17%) ⬇️
google/cloud/pubsub/subscriber_connection_test.cc 98.31% <0.00%> (+0.56%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 82.00% <0.00%> (+2.00%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3753156...bee617e. Read the comment docs.

@coryan coryan marked this pull request as ready for review July 14, 2022 19:55
@coryan coryan requested a review from a team as a code owner July 14, 2022 19:55
devbww
devbww approved these changes Jul 14, 2022
View reviewed changes
@google-cloud-cpp-bot
Copy link
Collaborator

google-cloud-cpp-bot commented Jul 14, 2022

Google Cloud Build Logs
For commit: bee617e8c816dbf1bd6a99c722404961da44dfd0

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan enabled auto-merge (squash) July 14, 2022 20:34
@coryan coryan merged commit b529b8c into googleapis:main Jul 14, 2022
@coryan coryan deleted the feat-storage-support-custom-placement-configs branch July 15, 2022 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@devbww devbww devbww approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

storage: Add Support for Updated Dual-Region Bucket API

3 participants

@coryan @google-cloud-cpp-bot @devbww