Skip to content

feat(beyondcorp): generate library #9555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
coryan merged 6 commits into from
Jul 25, 2022
Merged

feat(beyondcorp): generate library #9555

coryan merged 6 commits into from
Jul 25, 2022

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Jul 22, 2022 •
edited
Loading

Part of the work for #9340

This change is Reviewable

@coryan coryan changed the title Feat beyondcorp generate library feat(beyondcorp): generate library Jul 22, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

google-cloud-cpp-bot commented Jul 22, 2022

Google Cloud Build Logs
For commit: fe8b50611c03290190d4087e019fe1928040f401

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

google-cloud-cpp-bot commented Jul 22, 2022

Google Cloud Build Logs
For commit: e631fbccc8f1bc33c27e3eb3b3763fb2110d5348

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Jul 22, 2022 •
edited
Loading

Codecov Report

Merging #9555 (e67c880) into main (3f30044) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #9555   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files        1490     1490           
  Lines      137543   137543           
=======================================
+ Hits       129802   129807    +5     
+ Misses       7741     7736    -5
Impacted Files Coverage Δ
...le/cloud/storage/internal/curl_download_request.cc 87.62% <0.00%> (-1.01%) ⬇️
google/cloud/internal/curl_impl.cc 89.86% <0.00%> (+0.22%) ⬆️
...cloud/pubsub/internal/subscription_session_test.cc 98.49% <0.00%> (+0.50%) ⬆️
...le/cloud/internal/default_completion_queue_impl.cc 97.15% <0.00%> (+0.56%) ⬆️
...loud/bigtable/internal/connection_refresh_state.cc 98.61% <0.00%> (+2.77%) ⬆️
...e/cloud/pubsublite/internal/alarm_registry_impl.cc 100.00% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f30044...e67c880. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Collaborator

google-cloud-cpp-bot commented Jul 22, 2022

Google Cloud Build Logs
For commit: e67c8808c6981fde0c77f7357c8f1269576742d3

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review July 22, 2022 22:56
@coryan coryan requested a review from a team as a code owner July 22, 2022 22:56
@coryan coryan merged commit cf4c40b into googleapis:main Jul 25, 2022
@coryan coryan deleted the feat-beyondcorp-generate-library branch July 25, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbolduc dbolduc dbolduc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coryan @google-cloud-cpp-bot @dbolduc