Skip to content

fix(bigtable): the mocks library is no longer header-only#9568

Merged
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-bigtable-install-mocking-library
Jul 26, 2022
Merged

fix(bigtable): the mocks library is no longer header-only#9568
coryan merged 1 commit intogoogleapis:mainfrom
coryan:feat-bigtable-install-mocking-library

Conversation

@coryan
Copy link
Contributor

@coryan coryan commented Jul 26, 2022 •
edited
Loading

The library is no longer header-only, it needs to become a real library.

Part of the work for #5782

This change is Reviewable

@coryan
fix(bigtable): the mocks library is no longer header-only
9efd4ee 
The library is no longer header-only, it needs to become a real library.
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Jul 26, 2022
@google-cloud-cpp-bot
Copy link
Collaborator

google-cloud-cpp-bot commented Jul 26, 2022

Google Cloud Build Logs
For commit: 9efd4ee76e5443b613842c93055905a3edaa0237

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

dbolduc
dbolduc approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@codecov
Copy link

codecov bot commented Jul 26, 2022 •
edited
Loading

Codecov Report

Merging #9568 (9efd4ee) into main (29ff9d3) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #9568   +/-   ##
=======================================
  Coverage   94.37%   94.37%           
=======================================
  Files        1491     1491           
  Lines      137643   137643           
=======================================
+ Hits       129900   129904    +4     
+ Misses       7743     7739    -4
Impacted Files Coverage Δ
google/cloud/internal/curl_rest_client.cc 96.85% <0.00%> (-0.79%) ⬇️
...le/cloud/internal/default_completion_queue_impl.cc 96.59% <0.00%> (-0.57%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 97.98% <0.00%> (ø)
google/cloud/pubsub/samples/samples.cc 90.77% <0.00%> (+0.07%) ⬆️
google/cloud/storage/parallel_upload.cc 98.61% <0.00%> (+0.34%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.00% <0.00%> (+2.00%) ⬆️
...loud/bigtable/internal/connection_refresh_state.cc 98.61% <0.00%> (+2.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29ff9d3...9efd4ee. Read the comment docs.

@coryan coryan marked this pull request as ready for review July 26, 2022 14:06
@coryan coryan requested a review from a team as a code owner July 26, 2022 14:06
@coryan coryan enabled auto-merge (squash) July 26, 2022 14:07
@coryan coryan merged commit f8d1216 into googleapis:main Jul 26, 2022
@coryan coryan deleted the feat-bigtable-install-mocking-library branch July 26, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbolduc dbolduc dbolduc approved these changes

Assignees

No one assigned

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@coryan @google-cloud-cpp-bot @dbolduc