Added retryable errors. by mderka · Pull Request #700 · googleapis/google-cloud-java

mderka · 2016-03-01T20:00:19Z

No description provided.

gcloud-java-dns/src/main/java/com/google/gcloud/dns/DnsException.java


+  // see: https://cloud.google.com/dns/troubleshooting
+  private static final Set<Error> RETRYABLE_ERRORS = ImmutableSet.of(
+      new Error(404, null),


aozarov · 2016-03-01T21:04:31Z

Looks good. Please get some feedback from the DNS team before merge.

mderka · 2016-03-01T21:12:41Z

Can we get some input here? Are there any retryable errors that you know of and we are forgetting? We actually found none except for the 500s.

/cc @benvitale @blowmage @stephenplusplus

blowmage · 2016-03-01T23:28:36Z

The only guidance we've gotten for retries is a 500 or 503 response, and an error message reason for exceeding rate limits.

mderka · 2016-03-02T00:11:06Z

Thanks @blowmage, I added the exceeding limits.

stephenplusplus · 2016-03-02T15:44:04Z

Here are the codes that we use: https://github.com/GoogleCloudPlatform/gcloud-node/blob/058d7623ea3d54c0efc7db4757510fd53eabc492/lib/common/util.js#L271

mderka · 2016-03-02T16:24:25Z

@stephenplusplus 429 is the error code for rateLimitExceeded and userRateLimitExceeded, right? Is there any reason why you are double checking first via code and then via error message?

stephenplusplus · 2016-03-02T16:30:20Z

This code has been around for a while, so I'm a little rusty on why we went with the specific codes and ways of checking. But, the code check is when a response has the HTTP status code of 429, 500, 502, or 503. The other check isn't actually checking the HTTP status message, but a message that is contained in JSON response body errors object. I'm not sure if a situation exists where the status code could be 2xx, but the response body would return errors that occurred, but this check would handle it.

Added retryable errors.

benvitale · 2016-03-03T00:39:35Z

Jacob, David for additional comments

Retrying on 500 seems valuable; as this error could indicate a problem
between Apiary and our backend server.
I can't think of other cases. We generally have retry-loops around our
Spanner transactions, so if our server says things are errors, they are
unlikely to be temporary errors that could succeed if retried.

On Wed, Mar 2, 2016 at 7:33 PM, Martin Derka notifications@github.com
wrote:

Merged #700 #700.

—
Reply to this email directly or view it on GitHub
#700 (comment)
.

🤖 I have created a release *beep* *boop* --- ## [2.3.0](googleapis/java-tasks@v2.2.0...v2.3.0) (2022-07-01) ### Features * Enable REST transport for most of Java and Go clients ([#690](googleapis/java-tasks#690)) ([32f6d5c](googleapis/java-tasks@32f6d5c)) ### Documentation * **sample:** clean up README for native image sample ([#697](googleapis/java-tasks#697)) ([c6fa224](googleapis/java-tasks@c6fa224)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#701](googleapis/java-tasks#701)) ([c5b5405](googleapis/java-tasks@c5b5405)) * update dependency org.graalvm.buildtools:junit-platform-native to v0.9.12 ([#699](googleapis/java-tasks#699)) ([d2c32c2](googleapis/java-tasks@d2c32c2)) * update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#700](googleapis/java-tasks#700)) ([8d383d6](googleapis/java-tasks@8d383d6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…4.0 (#700) * chore(deps): update dependency com.google.cloud:libraries-bom to v25.4.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Alice <65933803+alicejli@users.noreply.github.com>

…onfig to v1.5.1 (#700) * build(deps): update dependency com.google.cloud:google-cloud-shared-config to v1.5.1 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

…onfig to v1.5.1 (#700)

Ignore ITSystemTest because the backend removed the implementation and the whole client library will be removed soon.

🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.3.2](googleapis/java-game-servers@v2.3.1...v2.3.2) (2022-08-09) ### Bug Fixes * Ignore ITSystemTest ([#700](googleapis/java-game-servers#700)) ([ca6fc58](googleapis/java-game-servers@ca6fc58)) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#697](googleapis/java-game-servers#697)) ([6dd8622](googleapis/java-game-servers@6dd8622)) * update dependency com.google.code.gson:gson to v2.9.1 ([#698](googleapis/java-game-servers#698)) ([6d6624c](googleapis/java-game-servers@6d6624c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…1.0 (#700) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.0.0` -> `26.1.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/compatibility-slim/26.0.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/26.1.0/confidence-slim/26.0.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-servicedirectory).

🤖 I have created a release *beep* *boop* --- ## [2.1.5](googleapis/java-dns@v2.1.4...v2.1.5) (2022-09-08) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#699](googleapis/java-dns#699)) ([0ae4803](googleapis/java-dns@0ae4803)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

🤖 I have created a release *beep* *boop* --- ## [2.2.3](googleapis/java-webrisk@v2.2.2...v2.2.3) (2022-09-09) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#700](googleapis/java-webrisk#700)) ([93f495c](googleapis/java-webrisk@93f495c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

…1575) (#700) Source-Link: googleapis/synthtool@2e9ac19 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:8175681a918181d306d9c370d3262f16b4c724cc73d74111b7d42fc985ca7f93

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [googleapis-common-protos](https://togithub.com/googleapis/python-api-common-protos) | `==1.56.3` -> `==1.56.4` | [![age](https://badges.renovateapi.com/packages/pypi/googleapis-common-protos/1.56.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/pypi/googleapis-common-protos/1.56.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/pypi/googleapis-common-protos/1.56.4/compatibility-slim/1.56.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/pypi/googleapis-common-protos/1.56.4/confidence-slim/1.56.3)](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-mediatranslation).

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 1, 2016

mderka added the api: dns Issues related to the Cloud DNS API. label Mar 1, 2016

aozarov reviewed Mar 1, 2016
View reviewed changes

gcloud-java-dns/src/main/java/com/google/gcloud/dns/DnsException.java Outdated

// see: https://cloud.google.com/dns/troubleshooting

private static final Set<Error> RETRYABLE_ERRORS = ImmutableSet.of(

new Error(404, null),

This comment was marked as spam.

Sign in to view

mderka force-pushed the retries branch 2 times, most recently from f022fcb to e8620a3 Compare March 1, 2016 21:02

Added retryable errors.

9b6929b

mderka force-pushed the retries branch from e8620a3 to 9b6929b Compare March 1, 2016 21:03

Added retries for userRateLimitExceeded and rateLimitExceeded.

4f28101

mderka force-pushed the retries branch from 5b7f328 to 4f28101 Compare March 2, 2016 20:39

mderka added a commit that referenced this pull request Mar 3, 2016

Merge pull request #700 from mderka/retries

030e819

Added retryable errors.

mderka merged commit 030e819 into googleapis:dns-alpha Mar 3, 2016

github-actions bot pushed a commit that referenced this pull request Jun 21, 2022

chore: include generated samples dir (#700)

e58f38e

github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this pull request Jun 29, 2022

chore: update release-level in .repo-metadata.json (googleapis#700)

f3ae815

github-actions bot pushed a commit that referenced this pull request Jul 14, 2022

chore: add native image checks as required (#700)

78e6166

github-actions bot pushed a commit that referenced this pull request Jul 14, 2022

build(deps): update dependency com.google.cloud:google-cloud-shared-c…

572bfa7

…onfig to v1.5.1 (#700)

github-actions bot pushed a commit that referenced this pull request Aug 9, 2022

fix: Ignore ITSystemTest (#700)

ca6fc58

Ignore ITSystemTest because the backend removed the implementation and the whole client library will be removed soon.

github-actions bot pushed a commit that referenced this pull request Aug 11, 2022

chore(main): release 2.4.2 (#700)

1b2aac2

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

meltsufin pushed a commit that referenced this pull request Dec 22, 2025

chore: change branch master to main in github configurations (#700)

6ba4da1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added retryable errors.#700

Added retryable errors.#700
mderka merged 2 commits intogoogleapis:dns-alphafrom
mderka:retries

mderka commented Mar 1, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Mar 1, 2016

Uh oh!

mderka commented Mar 1, 2016

Uh oh!

blowmage commented Mar 1, 2016

Uh oh!

mderka commented Mar 2, 2016

Uh oh!

stephenplusplus commented Mar 2, 2016

Uh oh!

mderka commented Mar 2, 2016

Uh oh!

stephenplusplus commented Mar 2, 2016

Uh oh!

benvitale commented Mar 3, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

mderka commented Mar 1, 2016

Uh oh!

This comment was marked as spam.

Uh oh!

aozarov commented Mar 1, 2016

Uh oh!

mderka commented Mar 1, 2016

Uh oh!

blowmage commented Mar 1, 2016

Uh oh!

mderka commented Mar 2, 2016

Uh oh!

stephenplusplus commented Mar 2, 2016

Uh oh!

mderka commented Mar 2, 2016

Uh oh!

stephenplusplus commented Mar 2, 2016

Uh oh!

benvitale commented Mar 3, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants