Skip to content

fix(spanner): be permissive about merging an empty struct #10079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2020
Merged

fix(spanner): be permissive about merging an empty struct #10079

merged 1 commit into from
Jan 23, 2020

Conversation

larkee
Copy link
Contributor

@larkee larkee commented Jan 9, 2020

Closes #10020

@larkee larkee requested a review from tseaver January 9, 2020 01:03
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 9, 2020
@larkee larkee requested a review from busunkim96 January 9, 2020 01:14
@busunkim96 busunkim96 changed the title Be permissive about merging an empty struct. fix(spanner): be permissive about merging an empty struct Jan 9, 2020
@skuruppu skuruppu merged commit c61c238 into googleapis:master Jan 23, 2020
@larkee larkee deleted the issue-10020 branch January 23, 2020 04:18
This was referenced Jan 29, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
@yoshi-automation yoshi-automation mentioned this pull request Jan 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver Awaiting requested review from tseaver

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

@busunkim96 busunkim96 Awaiting requested review from busunkim96

1 more reviewer

@skuruppu skuruppu skuruppu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spanner: IndexError: pop from empty list in _merge_struct
3 participants
@larkee @skuruppu @googlebot