Skip to content

fix(dns): update test assertion and core version pins #10096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 10, 2020
Merged

fix(dns): update test assertion and core version pins #10096

merged 2 commits into from
Jan 10, 2020

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jan 10, 2020

Towards #10088.

PR checklist

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

plamut added 2 commits January 10, 2020 15:47
@plamut
Adjust request params assertion in test (timeout)
4ae92d9
@plamut
Update version pin for core dependency
8649dbd 
Version bump is needed, as timeouts were introduced to API core.
@plamut plamut added the api: dns Issues related to the Cloud DNS API. label Jan 10, 2020
@plamut plamut requested a review from busunkim96 as a code owner January 10, 2020 15:51
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 10, 2020
@plamut plamut merged commit 561dced into googleapis:master Jan 10, 2020
@plamut plamut deleted the fix-tests-dns branch January 10, 2020 17:57
This was referenced Jan 29, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: dns Issues related to the Cloud DNS API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@plamut @busunkim96 @googlebot