Skip to content

chore(pubsub): declaratively drop Python 3.4 support #10168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2020
Merged

chore(pubsub): declaratively drop Python 3.4 support #10168

merged 1 commit into from
Jan 16, 2020
+1 −1

Conversation

plamut
Copy link
Contributor

@plamut plamut commented Jan 16, 2020

Fixes #10167.

This PR declaratively drops Python 3.4 support by constraining installation on Python 3.4 with the corresponding option in setup.py.

PR checklist:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@plamut plamut added the api: pubsub Issues related to the Pub/Sub API. label Jan 16, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 16, 2020
@plamut plamut merged commit ae7ef87 into googleapis:master Jan 16, 2020
@plamut plamut deleted the drop-python-34 branch January 16, 2020 21:34
This was referenced Jan 29, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anguillanneuf anguillanneuf Awaiting requested review from anguillanneuf

1 more reviewer

@pradn pradn pradn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PubSub: declaratively drop Python 3.4 support

3 participants

@plamut @pradn @googlebot