Making new Pub / Sub and API core releases. #4559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
Lgtm
…On Fri, Dec 8, 2017, 3:14 PM Danny Hermes ***@***.***> wrote:
@dhermes <https://github.com/dhermes> requested your review on:
googleapis/google-cloud-python#4559
<#4559>
Making new Pub / Sub and API core releases. as a code owner.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#4559 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUc-DmMYgv4ZAZc4CTrkHI8toGm2vwks5s-cLmgaJpZM4Q7xAl>
.
|
|
I am going to merge since |
|
Reason I am OK with that merge: this PR had virtually zero code changes (other than New tag pushed for |
|
I just realized I missed 4 PRs in @jonparrott Would you mind upgrading the release notes with a summary? (I'm assuming you will have better knowledge of those PRs and can write a better summary than I can, but if not, punt back to me.) |
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Dec 8, 2017
|
Here is the Pub / Sub build that will push to PyPI. |
dhermes
added a commit
to dhermes/google-cloud-python
that referenced
this pull request
Dec 11, 2017
dhermes
added a commit
that referenced
this pull request
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.