Skip to content

DO NOT MERGE: SecurityCenter: removes encoding marker from proto-generated file #6373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dpebot wants to merge 1 commit into from
Closed

DO NOT MERGE: SecurityCenter: removes encoding marker from proto-generated file #6373

dpebot wants to merge 1 commit into from

Conversation

@dpebot
Copy link
Contributor

@dpebot dpebot commented Nov 2, 2018

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Cloning googleapis.
synthtool > Running generator for google/cloud/securitycenter/artman_securitycenter_v1beta1.yaml.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/securitycenter-v1beta1.
synthtool > Replaced '::\n\n\\s+(compare_duration, but present at [a-z]+_time.)' in google/cloud/securitycenter_v1beta1/gapic/security_center_client.py.
synthtool > Replaced '::\n\n\\s+(compare_duration, but not present at [a-z]+_time.)' in google/cloud/securitycenter_v1beta1/gapic/security_center_client.py.
synthtool > Replaced '(^\\s+)::\n\n\\s+(start and the end of the time period defined by\n)\\s+(compare_duration and [a-z]+_time.)' in google/cloud/securitycenter_v1beta1/gapic/security_center_client.py.
synthtool > Cleaned up 0 temporary directories.

@dpebot dpebot requested a review from crwilcox as a code owner November 2, 2018 12:18
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2018
@tseaver tseaver changed the title [CHANGE ME] Re-generated securitycenter to pick up changes in the API or client library generator. Security Center: add encoding marker to proto-generated files Nov 2, 2018
tseaver
tseaver suggested changes Nov 2, 2018
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope: that line is required for Python 2.7.

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 2, 2018
@tseaver tseaver changed the title Security Center: add encoding marker to proto-generated files DO NOT MERGE: SecurityCenter: removes encoding marker from proto-generated file Nov 2, 2018
@tseaver tseaver mentioned this pull request Nov 7, 2018
Merged
@tseaver tseaver closed this in #6438 Nov 7, 2018
tseaver added a commit that referenced this pull request Nov 7, 2018
@tseaver
Fix client_info bug, update docstrings via synth. (#6438)
d767532 
Remove now-spurious replacements from synth.

Enforce encoding header in protoc-generated files in synth.

Closes #6373.
@tseaver tseaver deleted the autosynth-securitycenter branch November 7, 2018 16:48
parthea pushed a commit that referenced this pull request Jun 4, 2023
@tseaver
Fix client_info bug, update docstrings via synth. (#6438)
c634e12 
Remove now-spurious replacements from synth.

Enforce encoding header in protoc-generated files in synth.

Closes #6373.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@tseaver tseaver tseaver requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dpebot @tseaver @googlebot