Skip to content

Api_core: Convert 'DatetimeWithNanos' to / from 'google.protobuf.timestamp_pb2.Timestamp' #6919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 13, 2018
Merged

Api_core: Convert 'DatetimeWithNanos' to / from 'google.protobuf.timestamp_pb2.Timestamp' #6919

merged 4 commits into from
Dec 13, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Dec 13, 2018

Toward #6547

@tseaver
Group tests for 'DatetimeWithNanos' into a single class.
8009f13
@tseaver
Add 'DatetimeWithNanos.timestamp_pb' helper.
b00e951 
Converts to 'google.protobuf.timestamp_pb2.Timestamp' message.

Toward #6547.
@tseaver
Add 'DatetimeWithNanos.from_timestamp_pb' factory.
9a5308a 
Converts from 'google.protobuf.timestamp_pb2.Timestamp' message.

Toward #6547.
@tseaver tseaver requested a review from crwilcox December 13, 2018 18:03
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 13, 2018
@tseaver tseaver mentioned this pull request Dec 13, 2018
Merged
@tseaver tseaver merged commit df51357 into googleapis:master Dec 13, 2018
@tseaver tseaver deleted the 6547-api_core-timestamp-datetime_with_nanos-helpers branch December 13, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@crwilcox crwilcox crwilcox approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @crwilcox @googlebot