Skip to content

Adds a ready event to BackgroundConsumer to wait on start. #7499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2019
Merged

Adds a ready event to BackgroundConsumer to wait on start. #7499

merged 2 commits into from
Mar 12, 2019

Conversation

crwilcox
Copy link
Contributor

Adds a ready event to BackgroundConsumer to allow waiting for the background thread to start

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 11, 2019
@crwilcox
Copy link
Contributor Author

crwilcox commented Mar 11, 2019 •
edited
Loading

There exists a race of sorts where we thrash if we get retryable errors. Because it is possible to look at is_alive and it isn't. By adding this wait, and hardening is_active, this should be resolved.


[2019-03-08 05:16:41,878][139688736467728][][DEBUG][google.api_core.bidi][bidi.py:340][_on_call_done] Re-opening stream from gRPC callback.
[2019-03-08 05:16:41,884][139688736467728][][DEBUG][google.api_core.bidi][bidi.py:347][_reopen] Stream was already re-established.
[2019-03-08 05:16:41,886][139688736467728][][INFO][google.cloud.pubsub_v1.subscriber._protocol.streaming_pull_manager][streaming_pull_manager.py:449][_should_recover] Observed recoverable stream error 503 channel is in state TRANSIENT_FAILURE
[2019-03-08 05:16:41,886][139688736467728][][DEBUG][google.api_core.bidi][bidi.py:340][_on_call_done] Re-opening stream from gRPC callback.
[2019-03-08 05:16:41,888][139688736467728][][INFO][google.api_core.bidi][bidi.py:372][_reopen] Re-established stream
[2019-03-08 05:16:41,889][139688736467728][][INFO][google.cloud.pubsub_v1.subscriber._protocol.streaming_pull_manager][streaming_pull_manager.py:449][_should_recover] Observed recoverable stream error 503 channel is in state TRANSIENT_FAILURE
[2019-03-08 05:16:41,891][139688736467728][][DEBUG][google.api_core.bidi][bidi.py:340][_on_call_done] Re-opening stream from gRPC callback.
[2019-03-08 05:16:41,893][139688736467728][][INFO][google.api_core.bidi][bidi.py:372][_reopen] Re-established stream
[2019-03-08 05:16:41,893][139688738589456][][DEBUG][google.api_core.bidi][bidi.py:394][_recoverable] Call to retryable <bound method ResumableBidiRpc._recv of <google.api_core.bidi.ResumableBidiRpc object at 0x7f0bd1cf78d0>> caused 503 channel is in state TRANSIENT_FAILURE.
[2019-03-08 05:16:41,893][139688738589456][][INFO][google.cloud.pubsub_v1.subscriber._protocol.streaming_pull_manager][streaming_pull_manager.py:449][_should_recover] Observed recoverable stream error 503 channel is in state TRANSIENT_FAILURE
[2019-03-08 05:16:41,894][139688738589456][][DEBUG][google.api_core.bidi][bidi.py:402][_recoverable] Re-opening stream from retryable <bound method ResumableBidiRpc._recv of <google.api_core.bidi.ResumableBidiRpc object at 0x7f0bd1cf78d0>>.
[2019-03-08 05:16:41,895][139688738589456][][INFO][google.api_core.bidi][bidi.py:372][_reopen] Re-established stream
[2019-03-08 05:16:41,895][139688736467728][][INFO][google.cloud.pubsub_v1.subscriber._protocol.streaming_pull_manager][streaming_pull_manager.py:449][_should_recover] Observed recoverable stream error 503 channel is in state TRANSIENT_FAILURE
[2019-03-08 05:16:41,895][139688736467728][][DEBUG][google.api_core.bidi][bidi.py:340][_on_call_done] Re-opening stream from gRPC callback.
[2019-03-08 05:16:41,896][139688736467728][][DEBUG][google.api_core.bidi][bidi.py:347][_reopen] Stream was already re-established.

@crwilcox crwilcox force-pushed the add-start-guard-bidi branch from 6003b7a to d18c955 Compare March 11, 2019 23:18
@crwilcox crwilcox force-pushed the add-start-guard-bidi branch from d18c955 to 5731cf9 Compare March 11, 2019 23:19
dpcollins-google
dpcollins-google reviewed Mar 11, 2019
View reviewed changes
dpcollins-google
dpcollins-google reviewed Mar 11, 2019
View reviewed changes
@crwilcox crwilcox requested a review from tseaver March 12, 2019 18:23
@crwilcox crwilcox merged commit b95c8c7 into googleapis:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

@busunkim96 busunkim96 Awaiting requested review from busunkim96

2 more reviewers

@dpcollins-google dpcollins-google dpcollins-google left review comments

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crwilcox @tseaver @dpcollins-google @googlebot