feat(pubsub): add stop method #9365

IlyaFaer · 2019-10-01T08:29:35Z

Add stop() method, which sends all outstanding messages and waits until all futures resolved. Similar features in Go and Java.

Closes #4913
Closes #6883

pubsub/google/cloud/pubsub_v1/publisher/client.py

pubsub/google/cloud/pubsub_v1/futures.py

pubsub/google/cloud/pubsub_v1/publisher/_batch/thread.py

pubsub/google/cloud/pubsub_v1/publisher/client.py

pradn

Looks good.

IlyaFaer · 2019-10-25T14:34:05Z

How about:
to make sure all publish requests completed, either in success or error.

No problem, pushed

pubsub/google/cloud/pubsub_v1/publisher/client.py

IlyaFaer · 2019-11-07T11:53:20Z

@pradn, thanks for leading me through
@kamalaboulhosn, well, it's now more close to what you proposed. Do you have any more comments? Or we could merge, I think

plamut

Looks good, including the locking (the code is also easier to reason about with the _batch_lock spanning across the entire bodies of the publish/stop methods).

Suggested two small improvements, if it's not too late (had to prioritize other stuff, apologies).

Edit: To clarify, this PR can be merged as-is if it's blocking other @pradn's work, and the suggested changes, if accepted, can be added separately.

pubsub/google/cloud/pubsub_v1/publisher/client.py

kamalaboulhosn · 2019-11-07T17:04:48Z

@pradn, thanks for leading me through
@kamalaboulhosn, well, it's now more close to what you proposed. Do you have any more comments? Or we could merge, I think

Works for me, thanks!

pubsub/google/cloud/pubsub_v1/publisher/client.py

Co-Authored-By: Peter Lamut <[email protected]>

plamut

Looks good, thanks for the quick changes!

feat(pubsub): add stop method

dad43aa

IlyaFaer added the api: pubsub Issues related to the Pub/Sub API. label Oct 1, 2019

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 1, 2019

feat(pubsub): add unit-test for stop method

ec7677c

IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2019

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2019

IlyaFaer commented Oct 1, 2019

View reviewed changes

pubsub/google/cloud/pubsub_v1/publisher/client.py Outdated Show resolved Hide resolved

IlyaFaer commented Oct 1, 2019

View reviewed changes

pubsub/google/cloud/pubsub_v1/futures.py Show resolved Hide resolved

IlyaFaer requested review from lukesneeringer, anguillanneuf and kamalaboulhosn October 1, 2019 09:38

IlyaFaer marked this pull request as ready for review October 1, 2019 09:38

IlyaFaer requested a review from plamut as a code owner October 1, 2019 09:38

pradn self-requested a review October 2, 2019 16:31

googleapis deleted a comment from tseaver Oct 4, 2019

pradn reviewed Oct 18, 2019

View reviewed changes

pubsub/google/cloud/pubsub_v1/publisher/_batch/thread.py Outdated Show resolved Hide resolved

Add comment for _futures. Change wait() conditions.

93b5ec8

pradn reviewed Oct 23, 2019

View reviewed changes

pubsub/google/cloud/pubsub_v1/publisher/_batch/thread.py Show resolved Hide resolved

IlyaFaer added 3 commits October 23, 2019 18:36

Move attribute comment

a0d82e6

Make stop() method non-blocking.

210abf0

Add one more assert for stop() method.

99bfc26

pradn reviewed Oct 25, 2019

View reviewed changes

pubsub/google/cloud/pubsub_v1/publisher/client.py Outdated Show resolved Hide resolved

pradn reviewed Oct 25, 2019

View reviewed changes

IlyaFaer added 2 commits October 25, 2019 16:41

Fix comment.

3216d84

Comment fix.

94d3023

pradn reviewed Oct 25, 2019

View reviewed changes

pubsub/google/cloud/pubsub_v1/publisher/client.py Outdated Show resolved Hide resolved

Add stopping lock.

3f53333

pradn reviewed Oct 28, 2019

View reviewed changes

pubsub/google/cloud/pubsub_v1/publisher/client.py Outdated Show resolved Hide resolved

Spelling mistake fix.

b63c176

pradn reviewed Nov 1, 2019

View reviewed changes

pubsub/google/cloud/pubsub_v1/publisher/client.py Show resolved Hide resolved

IlyaFaer added 3 commits November 4, 2019 15:10

Preventing race conditions while stopping publisher.

3ef412c

Fix test.

b1d515d

Lock method stop() completely.

2534467

pradn approved these changes Nov 6, 2019

View reviewed changes

plamut reviewed Nov 7, 2019

View reviewed changes

pubsub/google/cloud/pubsub_v1/publisher/client.py Outdated Show resolved Hide resolved

pubsub/google/cloud/pubsub_v1/publisher/client.py Show resolved Hide resolved

kamalaboulhosn approved these changes Nov 7, 2019

View reviewed changes

Small refactor.

45a6bf8

plamut reviewed Nov 7, 2019

View reviewed changes

pubsub/google/cloud/pubsub_v1/publisher/client.py Outdated Show resolved Hide resolved

Update pubsub/google/cloud/pubsub_v1/publisher/client.py

ba01ec1

Co-Authored-By: Peter Lamut <[email protected]>

plamut approved these changes Nov 7, 2019

View reviewed changes

pradn removed request for lukesneeringer and anguillanneuf November 7, 2019 18:05

pradn merged commit 1e7c0a6 into googleapis:master Nov 7, 2019

plamut mentioned this pull request Dec 2, 2019

PubSub: Force push a batch of messages #9906

Closed

yoshi-automation mentioned this pull request Jan 29, 2020

chore(bigquery): bump copyright year to 2020, tweak docstring formatting (via synth) #10225

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(pubsub): add stop method #9365

feat(pubsub): add stop method #9365

Uh oh!

IlyaFaer commented Oct 1, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pradn left a comment

Uh oh!

IlyaFaer commented Oct 25, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IlyaFaer commented Nov 7, 2019

Uh oh!

plamut left a comment •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

kamalaboulhosn commented Nov 7, 2019

Uh oh!

Uh oh!

plamut left a comment

Uh oh!

Uh oh!

feat(pubsub): add stop method #9365

feat(pubsub): add stop method #9365

Uh oh!

Conversation

IlyaFaer commented Oct 1, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pradn left a comment

Choose a reason for hiding this comment

Uh oh!

IlyaFaer commented Oct 25, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

IlyaFaer commented Nov 7, 2019

Uh oh!

plamut left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

kamalaboulhosn commented Nov 7, 2019

Uh oh!

Uh oh!

plamut left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

plamut left a comment •

edited

Loading