Skip to content

docs(tasks): disambiguate client requests from cloud task requests #9398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2019
Merged

docs(tasks): disambiguate client requests from cloud task requests #9398

merged 2 commits into from
Oct 8, 2019

Conversation

busunkim96
Copy link
Contributor

CC/ @averikitsch

Addressing internal issue 136504997

The create_task method refers to optional parameters - retry, timeout, and metadata. It is unclear to users that theses are configuration parameters for the client request not Cloud Task requests. (https://googleapis.dev/python/cloudtasks/latest/gapic/v2/api.html#google.cloud.tasks_v2.CloudTasksClient.create_task)

Please update the language to reflect that these affect the client request not Cloud Tasks.

Any wording suggestions would be much appreciated.

@busunkim96 busunkim96 added the api: cloudtasks Issues related to the Cloud Tasks API. label Oct 4, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 4, 2019
@busunkim96 busunkim96 requested a review from crwilcox October 7, 2019 17:50
@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 8, 2019
@busunkim96 busunkim96 merged commit 8e409a0 into googleapis:master Oct 8, 2019
parthea pushed a commit that referenced this pull request Sep 22, 2023
@busunkim96
docs(tasks): disambiguate client requests from cloud task requests (#…
b42ac95 
…9398)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: cloudtasks Issues related to the Cloud Tasks API. cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busunkim96 @tseaver @googlebot