Skip to content

tests(dlp): normalize VPCSC configuration in systests #9608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 11, 2019
Merged

tests(dlp): normalize VPCSC configuration in systests #9608

merged 5 commits into from
Nov 11, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Nov 5, 2019

Toward #9580

@tseaver tseaver added testing api: dlp Issues related to the Sensitive Data Protection API. labels Nov 5, 2019
@tseaver tseaver requested a review from busunkim96 as a code owner November 5, 2019 22:53
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 5, 2019
@tseaver tseaver mentioned this pull request Nov 5, 2019
Closed
10 tasks
busunkim96
busunkim96 approved these changes Nov 5, 2019
View reviewed changes
@tseaver
Remove debugging pdb.
0584705
@tseaver
test: all these tests must run inside VPCSC
ca16b96 
- Move 'skip_unless_inside_vpcsc' to class scope.
- Drop 'skip_unless_outside_project':  it is guaranteed to be set when
  running tests inside VPCSC.
- Drop never-reached branch for outside in '_do_test'.
- Don't swallow unexpected exceptions inside '_is_rejected.
@tseaver
fix: blacken noxfile.py
56b8b42
@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 6, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Nov 6, 2019

I tagged with "do not merge" because I believe we should refactor all these un-idiomatic tests along the lines of the changes in #9618.

@tseaver
Copy link
Contributor Author

tseaver commented Nov 11, 2019

@busunkim96 I removed the "do not merge" label after updating the tests to follow the pattern in #9618.

@tseaver tseaver removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 11, 2019
@tseaver tseaver merged commit 3dab9f3 into googleapis:master Nov 11, 2019
@tseaver tseaver deleted the 9580-dlp-normalize-vpcsc-config branch November 11, 2019 22:24
@tseaver tseaver mentioned this pull request Nov 13, 2019
Closed
@yoshi-automation yoshi-automation mentioned this pull request Jan 29, 2020
Merged
parthea pushed a commit that referenced this pull request Sep 22, 2023
@tseaver
tests(dlp): normalize VPCSC configuration in systests (#9608)
7f04e61 
Toward #9580.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: dlp Issues related to the Sensitive Data Protection API. cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tseaver @busunkim96 @googlebot