fix: Add tests for multiple inequality support#1392
Merged
Conversation
product-auto-label
bot
added
size: l
milaGGL
changed the title
milaGGL
added
the
do not merge
milaGGL
commented
Aug 15, 2023
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FieldPath.java
Show resolved
Hide resolved
ehsannas
reviewed
Aug 15, 2023
Contributor
ehsannas
left a comment
ehsannas
left a comment
There was a problem hiding this comment.
A few nits pointed out below.
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITSystemTest.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITQueryTest.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FieldPath.java
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FieldPath.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java
Outdated
Show resolved
Hide resolved
ehsannas
reviewed
Aug 17, 2023
Contributor
ehsannas
left a comment
ehsannas
left a comment
There was a problem hiding this comment.
Generally LGTM. Just a few minor nits below.
google-cloud-firestore/src/main/java/com/google/cloud/firestore/Query.java
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITQueryTest.java
Outdated
Show resolved
Hide resolved
google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITQueryTest.java
Outdated
Show resolved
Hide resolved
ehsannas
approved these changes
Aug 31, 2023
ehsannas
approved these changes
Sep 12, 2023
google-cloud-firestore/src/test/java/com/google/cloud/firestore/QueryTest.java
Show resolved
Hide resolved
ehsannas
reviewed
Sep 12, 2023
| public void multipleInequalityQueryOnDifferentPropertiesShouldBeSupported() throws Exception { | ||
| // TODO(MIEQ): Enable this test against production when possible. | ||
| assumeTrue( | ||
| "Skip this test if running against production because multiple equality is " |
Contributor
There was a problem hiding this comment.
typo: multiple inequality
milaGGL
removed
the
do not merge
milaGGL
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:run
ehsannas
approved these changes
Sep 13, 2023
milaGGL
changed the title
milaGGL
changed the title
cherylEnkidu
pushed a commit
that referenced
this pull request
Dec 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port integration tests from web SDK to make sure client and server sdks behaviours are consistent.
Update the
createImplicitOrderByfunction for queries with cursor.Updated the isInequality check to be consistent with mobile&web sdks:
https://github.com/firebase/firebase-js-sdk/blob/320e58cc57d0fc485548611c5975dd3df69f8d18/packages/firestore/src/core/filter.ts#L177
https://github.com/firebase/firebase-ios-sdk/blob/2eccf796524777ce8fae5b82c3e4b0d9875bb9af/Firestore/core/src/core/field_filter.cc#L146
https://github.com/firebase/firebase-android-sdk/blob/b7a34fb108f1d619f5cc98677582e585c239048a/firebase-firestore/src/main/java/com/google/firebase/firestore/core/FieldFilter.java#L145