refactor: Optimize FieldMask instantiation#1536
Merged
tom-andersen merged 2 commits intomainfrom Jan 19, 2024
Merged
Conversation
product-auto-label
bot
added
size: s
tom-andersen
changed the title
tom-andersen
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
dconeybe
requested changes
Jan 19, 2024
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FieldMask.java
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FieldMask.java
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FieldMask.java
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java
Show resolved
Hide resolved
dconeybe
approved these changes
Jan 19, 2024
Contributor
dconeybe
left a comment
dconeybe
left a comment
There was a problem hiding this comment.
LGTM. Thanks for this improvement, and for gracefully pointing out my uninformed review comments!
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FieldMask.java
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FieldMask.java
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/FieldMask.java
Show resolved
Hide resolved
google-cloud-firestore/src/main/java/com/google/cloud/firestore/UpdateBuilder.java
Show resolved
Hide resolved
tom-andersen
added a commit
that referenced
this pull request
Jan 22, 2024
* Optimize FieldMask instantiation * Pretty
tom-andersen
added a commit
that referenced
this pull request
Jan 24, 2024
* Thread safe UpdateBuilder * Add comment * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * chore: add an unmanaged dependency check (#1532) * refactor: Optimize FieldMask instantiation (#1536) * Optimize FieldMask instantiation * Pretty * Use synchronize * Update comment * Make sure commit prevents writes. * Pretty * Refactor * Add comments and make committed volatile. * Make WriteOperation immutable. * Refactor * fix(deps): Update the Java code generator (gapic-generator-java) to 2.32.0 (#1534) * chore: Add FindNearest API to the preview branch docs: Improve the documentation on Document.fields PiperOrigin-RevId: 599602467 Source-Link: googleapis/googleapis@d32bd97 Source-Link: googleapis/googleapis-gen@0545ffc Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDU0NWZmYzQ4OGI4MmQzYTQ3NzExMThjOTIzZDY0Y2QwYjc1OTk1MyJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * fix(deps): Update the Java code generator (gapic-generator-java) to 2.32.0 PiperOrigin-RevId: 599914188 Source-Link: googleapis/googleapis@17e6661 Source-Link: googleapis/googleapis-gen@d86ba5b Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDg2YmE1YmU1MzdlNDg5NDM1MTA1Y2E4NTU2NmNjNDEwMzMwMWFiYSJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * test(deps): update dependency com.google.truth:truth to v1.3.0 (#1538) * make some methods static: applyFieldMask() and convertToFieldPaths() * Comment * Inline * use explicit synchronization * Review feedback --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Joe Wang <[email protected]> Co-authored-by: gcf-owl-bot[bot] <78513119+gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Mend Renovate <[email protected]> Co-authored-by: Denver Coneybeare <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optimization does 2 things: