Skip to content
This repository was archived by the owner on Sep 19, 2023. It is now read-only.

deps: update dependency io.grpc:grpc-bom to v1.35.0#248

Merged
stephaniewang526 merged 3 commits intogoogleapis:masterfrom
renovate-bot:renovate/grpc.version
Feb 2, 2021
Merged

deps: update dependency io.grpc:grpc-bom to v1.35.0#248
stephaniewang526 merged 3 commits intogoogleapis:masterfrom
renovate-bot:renovate/grpc.version

Conversation

@renovate-bot
Copy link
Contributor

@renovate-bot renovate-bot commented Jan 13, 2021 •
edited
Loading

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
io.grpc:grpc-bom 1.34.1 -> 1.35.0 age adoption passing confidence

Release Notes

grpc/grpc-java

v1.35.0

Compare Source

gRPC Java 1.35.0 Release Notes

Bug Fixes

  • core: Fix CompositeChannelCredentials to no longer use CallCredentials for OOB channels. OOB channels are available for load balancing policies to use to communicate with an LB server. It is mainly used by gRPC-LB. This resolves the incompatibility of the 1.34.0 release with googleapis.com.
  • alts: Limit number of concurrent handshakes to 32. ALTS uses blocking RPCs for handshakes. If the handshake server has a limit to number of concurrent handshakes this can produce a deadlock. Limiting to 32 should workaround the problem for the majority of the cases. A later fix will allow handshake RPCs to be asynchronous
  • xds: Fix missed class relocations for generated code. grpc-xds previously exposed generated code for multiple 3rd-party protobuf generated code classes outside of the io.grpc package. They are now shaded to avoid colliding with other users of the classes
  • xds: Fix a user visible stack trace showing java.util.NoSuchElementException when the environment variable GRPC_XDS_EXPERIMENTAL_SECURITY_SUPPORT was set and the application contains an xDS configured gRPC server. The exception was benign and was seen when the connection was dropped before an SslContextProvider was available.
  • xds: decouple xds channel creation and bootstrapping. This fixes the bug caused by the lifecycle mismatch between XdsClient and its channel to the xDS server. Cheating a new XdsClient (previous one shutdown due to no Channel using it) would create and use a new xDS channel.

Dependencies

  • Guava updated to 30.0-android
  • Animal Sniffer annotations updated to 1.19
  • Error Prone annotations updated to 2.4.0
  • Perfmark updated to 0.23.0
  • compiler: Linux artifacts now built using CentOS 7. Previously CentOS 6 was used, but that distribution is discontinued and no longer available in our build infrastructure
  • netty: Upgrade to Netty 4.1.52 and tcnative 2.0.34. Note that this Netty release enables TLSv1.3 support. mTLS failures with TLSv1.3 will have different error messages than in TLSv1.2
  • auth,alts: google-auth-library-java updated to 0.22.2
  • census: OpenCensus updated to 0.28.0
  • protobuf: googleapi’s common protos updated to 2.0.1
  • okhttp: Okio updated to 1.17.5
  • xds: re2j updated to 1.5
  • xds: bouncycastle updated to 1.67
  • gradle: bumped protobuf-gradle-plugin version to 0.8.14
  • android, cronet: upgraded the latest support Android version to 29

Acknowledgments

@​amnox
@​horizonzy
@​wanyingd1996

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate-bot renovate-bot requested a review from a team as a code owner January 13, 2021 06:04
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 13, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 13, 2021
@stephaniewang526 stephaniewang526 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 13, 2021
@stephaniewang526
Copy link
Contributor

stephaniewang526 commented Jan 13, 2021 •
edited
Loading

opencensus is updated to v0.28.0 which is causing dependency conflict with gax v1.60.1. Updateing OpenCensus version to v0.28.0 in this commit.

@elharo elharo mentioned this pull request Jan 20, 2021
Closed
@renovate-bot renovate-bot force-pushed the renovate/grpc.version branch from 0f7f013 to ab82c24 Compare January 20, 2021 21:51
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 20, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 20, 2021
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2021
@stephaniewang526 stephaniewang526 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jan 27, 2021
elharo
elharo reviewed Jan 27, 2021
View reviewed changes
pom.xml Outdated
<animal-sniffer.version>1.19</animal-sniffer.version>
<iam.version>1.0.7</iam.version>
<opencensus.version>0.24.0</opencensus.version>
<opencensus.version>0.28.0</opencensus.version>
Copy link
Contributor

@elharo elharo Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were trying to avoid upgrading this one.

Copy link
Contributor

@chingor13 chingor13 Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are no breaking changes here and we should consider at least 0.28.1 which supposedly adds support for OpenTelemetry migration

Copy link
Contributor

@stephaniewang526 stephaniewang526 Jan 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 27, 2021
@suztomo
Copy link
Member

suztomo commented Jan 28, 2021

Looking forward to this PR getting merged and propagated to other artifacts. In a Beam's PR below, google-cloud-bigquerystorage is pulling an old grpc-api (1.34.1) which is not compatible with "io.grpc:grpc-core:1.35.0".

apache/beam#13765 (comment)

suztomo
suztomo previously approved these changes Jan 28, 2021
View reviewed changes
suztomo
suztomo reviewed Jan 28, 2021
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the dependency conflict between opencensus 0.28.1 and grpc-census 1.35.0.

io.grpc:grpc-census:1.35.0
1 target class causing linkage errors referenced from 1 source class.

(io.opencensus:opencensus-api:0.28.1) Class io.opencensus.trace.unsafe.ContextUtils has default access, referenced from io.grpc.census.CensusTracingModule

(from running cloud-opensource-java's DashboardMain against the pom in this branch)

Indeed, https://github.com/census-instrumentation/opencensus-java/releases/tag/v0.28.1 says "Breaking change: ContextUtils is no longer public".

@suztomo suztomo dismissed their stale review January 28, 2021 16:17

new finding

@suztomo
Copy link
Member

suztomo commented Jan 28, 2021

@stephaniewang526 Would you pick a compatible pair of OpenCensus and gRPC version? (https://search.maven.org/artifact/io.grpc/grpc-census/1.35.0/jar depends on 0.28.0, for example)

@stephaniewang526 stephaniewang526 merged commit 7a28c6e into googleapis:master Feb 2, 2021
@renovate-bot renovate-bot deleted the renovate/grpc.version branch February 2, 2021 21:04
@stephaniewang526 stephaniewang526 mentioned this pull request Feb 2, 2021
Merged
@release-please release-please bot mentioned this pull request Jul 13, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@elharo elharo Awaiting requested review from elharo

3 more reviewers

@suztomo suztomo suztomo left review comments

@stephaniewang526 stephaniewang526 stephaniewang526 left review comments

@chingor13 chingor13 chingor13 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@renovate-bot @stephaniewang526 @suztomo @chingor13 @elharo @yoshi-kokoro