Skip to content

fix: regenerate pb2 files using grpcio-tools #3080

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lingyinw wants to merge 3 commits into from
Closed

fix: regenerate pb2 files using grpcio-tools #3080

lingyinw wants to merge 3 commits into from

Conversation

@lingyinw
Copy link
Contributor

@lingyinw lingyinw commented Dec 8, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Get the necessary approvals
  • Once the last commit on the PR has been approved, add the "ready to pull" label to the Pull Request

Note: do not merge your PR from GitHub. Adding the "ready to pull" label is the final step in the review process.
After approvals, the changes in your PR will be committed to the main branch and this PR will be closed.

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Dec 8, 2023
@lingyinw lingyinw requested a review from parthea December 8, 2023 23:23
@lingyinw lingyinw added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 8, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Dec 8, 2023
parthea
parthea approved these changes Dec 9, 2023
View reviewed changes
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need to update https://github.com/googleapis/python-aiplatform/blob/main/google/cloud/aiplatform/matching_engine/_protos/match_service_pb2_grpc.py?

@lingyinw lingyinw added the ready to pull Ready to be merged into the codebase. label Dec 10, 2023
@lingyinw lingyinw removed the ready to pull Ready to be merged into the codebase. label Dec 10, 2023
@lingyinw
Copy link
Contributor Author

lingyinw commented Dec 11, 2023

Do we also need to update https://github.com/googleapis/python-aiplatform/blob/main/google/cloud/aiplatform/matching_engine/_protos/match_service_pb2_grpc.py?

I also ran the grpc update, but nothing changed for that file.

@lingyinw lingyinw added the ready to pull Ready to be merged into the codebase. label Dec 11, 2023
copybara-service bot pushed a commit that referenced this pull request Dec 11, 2023
@lingyinw @copybara-github
Copybara import of the project:
4158e53 
--
6a9864b by lingyinw <[email protected]>:

fix: regenerate pb2 files using grpcio-tools
COPYBARA_INTEGRATE_REVIEW=#3080 from lingyinw:main d7c84ac
PiperOrigin-RevId: 589927080
@lingyinw lingyinw closed this Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

Assignees

No one assigned

Labels

api: vertex-ai Issues related to the googleapis/python-aiplatform API. ready to pull Ready to be merged into the codebase. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lingyinw @parthea @yoshi-kokoro