Skip to content

fix: add clarity to parameters per user feedback #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrewferlitsch merged 8 commits into from
Dec 7, 2021
Merged

fix: add clarity to parameters per user feedback #886

andrewferlitsch merged 8 commits into from
Dec 7, 2021

Conversation

@andrewferlitsch
Copy link
Contributor

@andrewferlitsch andrewferlitsch commented Dec 6, 2021 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@andrewferlitsch andrewferlitsch requested review from a team as code owners December 6, 2021 19:07
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 6, 2021
@product-auto-label product-auto-label bot added the api: aiplatform Issues related to the AI Platform API. label Dec 6, 2021
morgandu
morgandu suggested changes Dec 7, 2021
View reviewed changes
@andrewferlitsch andrewferlitsch merged commit 37ee0a1 into main Dec 7, 2021
@andrewferlitsch andrewferlitsch deleted the 195711605 branch December 7, 2021 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leahecole leahecole Awaiting requested review from leahecole leahecole was automatically assigned from googleapis/python-samples-owners

1 more reviewer

@morgandu morgandu morgandu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: aiplatform Issues related to the AI Platform API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewferlitsch @morgandu @kweinmeister