Skip to content

tests: avoid use of systest envvars in unit tests #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tseaver merged 1 commit into from
Jul 28, 2020
Merged

tests: avoid use of systest envvars in unit tests #195

tseaver merged 1 commit into from
Jul 28, 2020
+10 −3

Conversation

@tseaver
Copy link
Contributor

@tseaver tseaver commented Jul 28, 2020

Fixes #194

@tseaver tseaver added type: process A process-related concern. May include testing, release, or the like. testing labels Jul 28, 2020
@tseaver tseaver requested a review from plamut July 28, 2020 17:27
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 28, 2020
@tseaver tseaver requested a review from busunkim96 July 28, 2020 20:53
@tseaver tseaver merged commit c4528e3 into master Jul 28, 2020
@tseaver tseaver deleted the 194-testing-unittests_pass_project branch July 28, 2020 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@plamut plamut Awaiting requested review from plamut

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement. testing type: process A process-related concern. May include testing, release, or the like.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unit tests should not rely on systest environ variables

2 participants

@tseaver @busunkim96