Skip to content

testing: split system tests #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 4, 2020
Merged

testing: split system tests #207

merged 5 commits into from
Aug 4, 2020

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Jul 31, 2020 •
edited
Loading

I manually run synthtool with the changes in googleapis/synthtool#712

Motivation: #191

Note that noxfile.py is skipped, so I manually updated it (probably ok)

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 31, 2020
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 1, 2020

@tseaver @shollyman @busunkim96 I can not assign a reviewer or add a label. Can you review?

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 1, 2020 •
edited
Loading

I checked the test logs and they work as expected:

  • main presubmit build is skipping system tests.
  • system-x.x build is only running a system test for a single python version.
  • presubmit is the slowest. It took 24min 40secs.

Another observation is that the snippets tests are taking long time. Once we move them out, the build will be much faster.

@busunkim96 busunkim96 requested review from plamut and shollyman August 1, 2020 01:11
@tseaver tseaver self-requested a review August 3, 2020 17:45
tseaver
tseaver suggested changes Aug 3, 2020
View reviewed changes
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 3, 2020

@tseaver Thanks, I opened googleapis/synthtool#713 which will allow us to use the template.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 3, 2020

@tseaver Tests are passing. I rebased to the master. PTAL

@tseaver tseaver self-requested a review August 4, 2020 16:35
@tseaver tseaver merged commit b842fb5 into googleapis:master Aug 4, 2020
@tmatsuo tmatsuo mentioned this pull request Aug 4, 2020
Closed
1 task
@tseaver tseaver mentioned this pull request Aug 10, 2020
Merged
jmgreger pushed a commit to jmgreger/python-bigquery that referenced this pull request Aug 31, 2020
testing: split system tests into separate builds (googleapis#207)
9ceeafc
gcf-merge-on-green bot pushed a commit that referenced this pull request Oct 16, 2020
@tseaver
tests: split out snippets builds (#219)
29dd573 
@tmatsuo Emulating PR #207. I don't know if I'm missing anything:  e.g., I don't quite understand what the `split_system_tests=True` does in the `synth.py` there.

Toward #191
@tseaver tseaver mentioned this pull request Jul 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut Awaiting requested review from plamut

@shollyman shollyman Awaiting requested review from shollyman

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmatsuo @tseaver