Skip to content

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Oct 6, 2022

No description provided.

@parthea parthea requested review from a team as code owners October 6, 2022 20:05
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 6, 2022
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Oct 6, 2022
"grpc-google-iam-v1 >=0.12.4, <1.0.0dev",
"proto-plus >= 1.22.0, <2.0.0dev",
"protobuf >= 3.20.2, <5.0.0dev",
"protobuf>=3.19.5,<5.0.0dev,!=3.20.0,!=3.20.1,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some context here? Why are these versions disallowed?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See go/tensorflow-python-client-libaries-dependency-issue internally

"grpc-google-iam-v1 >=0.12.4, <1.0.0dev",
"proto-plus >= 1.22.0, <2.0.0dev",
"protobuf >= 3.20.2, <5.0.0dev",
"protobuf>=3.19.5,<5.0.0dev,!=3.20.0,!=3.20.1,!=4.21.1,!=4.21.2,!=4.21.3,!=4.21.4,!=4.21.5",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See go/tensorflow-python-client-libaries-dependency-issue internally

@vchudnov-g vchudnov-g merged commit 12f3001 into main Oct 7, 2022
@vchudnov-g vchudnov-g deleted the allow-protobuf-3-19-5 branch October 7, 2022 20:50
parthea added a commit that referenced this pull request Oct 10, 2022
parthea added a commit that referenced this pull request Oct 10, 2022
* fix(deps): allow protobuf 3.19.5 (#644)

Co-authored-by: Daniel Sanche <[email protected]>

* update version/changelog

Co-authored-by: Daniel Sanche <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/python-logging API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants