This repository was archived by the owner on Sep 5, 2023. It is now read-only.
test: log message.data for debugging #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flaky test from #124 suggests that `message.data` might have been deformed somehow. Adding a logging for the data passed to help debug next time something goes wrong.
product-auto-label
bot
added
the
api: securitycenter
google-cla
bot
added
the
cla: yes
dandhlee
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
dandhlee
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
dinagraves
approved these changes
Apr 23, 2021
| @@ -31,6 +31,9 @@ def receive_notifications(project_id, subscription_name): | |||
| def callback(message): | |||
| print("Received message") | |||
There was a problem hiding this comment.
May I suggest:
print(f"Received message: {message.data}")
Contributor
Author
There was a problem hiding this comment.
That should be better! 👍
dandhlee
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
dandhlee
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Contributor
Author
|
waiting to hear back from the securitycenter team w.r.t the test failure. Waiting until the tests pass from the fix provided. |
dandhlee
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flaky test from #124 suggests that
message.datamight have been deformed somehow.Adding a logging for the data passed to help debug next time something goes wrong.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Updates #124