This repository was archived by the owner on Sep 5, 2023. It is now read-only.
chore: fix string replacement in owlbot.py#151
Merged
busunkim96 merged 2 commits intomasterfrom May 20, 2021
Merged
Conversation
product-auto-label
bot
added
the
api: securitycenter
google-cla
bot
added
the
cla: yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are commits, for example this one, in #147 from owlbot which are excessively commenting out the same line with
#. I think the issue is caused by this commit made in #143 and the fact that the owlbot will runowlbot.pyas part of the post-processing.At this line in
owlbot.py, we have a for loop that iterates through paths to the clean (aka un-hacked) versions of the generated client from googleapis-gen. Thes.replace()calls should be done in the for loop to ensure that we only run thes.replace()on clean versions of the generated client.