Skip to content
This repository was archived by the owner on Sep 5, 2023. It is now read-only.

chore: fix string replacement in owlbot.py #151

Merged
busunkim96 merged 2 commits into from
May 20, 2021
Merged

chore: fix string replacement in owlbot.py #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2596d0
chore: fix string replacement in owlbot.py
parthea May 20, 2021
dc9656e
chore: clean up excessive hash characters
parthea May 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions owlbot.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,19 @@
r"\g<1>settings resource.\n"
r"\g<1>If empty all mutable fields will be updated.",
)

# Comment out broken assertion in unit test
# https://github.com/googleapis/gapic-generator-python/issues/897
s.replace(
library / "tests/**/*.py",
"assert args\[0\]\.start_time == timestamp_pb2\.Timestamp\(seconds=751\)",
"# assert args[0].start_time == timestamp_pb2.Timestamp(seconds=751)"
)

s.move(library, excludes=["README.rst", "docs/index.rst", "setup.py"])

s.remove_staging_dirs()

# Comment out broken assertion in unit test
# https://github.com/googleapis/gapic-generator-python/issues/897
s.replace(
"tests/**/*.py",
"assert args\[0\]\.start_time == timestamp_pb2\.Timestamp\(seconds=751\)",
"# assert args[0].start_time == timestamp_pb2.Timestamp(seconds=751)"
)

# ----------------------------------------------------------------------------
# Add templated files
# ----------------------------------------------------------------------------
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/gapic/securitycenter_v1/test_security_center.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4817,7 +4817,7 @@ def test_set_finding_state_flattened():
_, args, _ = call.mock_calls[0]
assert args[0].name == "name_value"
assert args[0].state == finding.Finding.State.ACTIVE
# # # # # # # assert args[0].start_time == timestamp_pb2.Timestamp(seconds=751)
# assert args[0].start_time == timestamp_pb2.Timestamp(seconds=751)


def test_set_finding_state_flattened_error():
Expand Down Expand Up @@ -4862,7 +4862,7 @@ async def test_set_finding_state_flattened_async():
_, args, _ = call.mock_calls[0]
assert args[0].name == "name_value"
assert args[0].state == finding.Finding.State.ACTIVE
# # # # # # # assert args[0].start_time == timestamp_pb2.Timestamp(seconds=751)
# assert args[0].start_time == timestamp_pb2.Timestamp(seconds=751)


@pytest.mark.asyncio
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/gapic/securitycenter_v1beta1/test_security_center.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3622,7 +3622,7 @@ def test_set_finding_state_flattened():
_, args, _ = call.mock_calls[0]
assert args[0].name == "name_value"
assert args[0].state == finding.Finding.State.ACTIVE
# # # # # # # assert args[0].start_time == timestamp_pb2.Timestamp(seconds=751)
# assert args[0].start_time == timestamp_pb2.Timestamp(seconds=751)


def test_set_finding_state_flattened_error():
Expand Down Expand Up @@ -3667,7 +3667,7 @@ async def test_set_finding_state_flattened_async():
_, args, _ = call.mock_calls[0]
assert args[0].name == "name_value"
assert args[0].state == finding.Finding.State.ACTIVE
# # # # # # # assert args[0].start_time == timestamp_pb2.Timestamp(seconds=751)
# assert args[0].start_time == timestamp_pb2.Timestamp(seconds=751)


@pytest.mark.asyncio
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/gapic/securitycenter_v1p1beta1/test_security_center.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4975,7 +4975,7 @@ def test_set_finding_state_flattened():
_, args, _ = call.mock_calls[0]
assert args[0].name == "name_value"
assert args[0].state == finding.Finding.State.ACTIVE
# # # # # # # assert args[0].start_time == timestamp_pb2.Timestamp(seconds=751)
# assert args[0].start_time == timestamp_pb2.Timestamp(seconds=751)


def test_set_finding_state_flattened_error():
Expand Down Expand Up @@ -5020,7 +5020,7 @@ async def test_set_finding_state_flattened_async():
_, args, _ = call.mock_calls[0]
assert args[0].name == "name_value"
assert args[0].state == finding.Finding.State.ACTIVE
# # # # # # # assert args[0].start_time == timestamp_pb2.Timestamp(seconds=751)
# assert args[0].start_time == timestamp_pb2.Timestamp(seconds=751)


@pytest.mark.asyncio
Expand Down