Skip to content
This repository was archived by the owner on Feb 23, 2024. It is now read-only.

chore: add split repo templates #1

Merged
merged 10 commits into from
Jan 31, 2020
Merged

chore: add split repo templates #1

merged 10 commits into from
Jan 31, 2020

Conversation

leahecole
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 31, 2020
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 31, 2020
@busunkim96
Copy link
Contributor

coverage:

You can drop the expected level to 95% in synth.py (which will adjust the noxfile). The missing coverage in __init__.py and translate.py are known issues with the generated libraries.

Creating virtual environment (virtualenv) using python3.7 in .nox/cover
pip install coverage pytest-cov
coverage report --show-missing --fail-under=100
Name                                         Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------------------------------------
google/cloud/__init__.py                         6      6      0      0     0%   17-24
google/cloud/translate.py                        4      4      0      0     0%   18-24
google/cloud/translate_v2/__init__.py            5      0      0      0   100%
google/cloud/translate_v2/_http.py              13      0      0      0   100%
google/cloud/translate_v2/client.py             68      0     32      0   100%
google/cloud/translate_v3/__init__.py           11      0      2      0   100%
google/cloud/translate_v3/types.py              17      0      4      0   100%
google/cloud/translate_v3beta1/__init__.py      11      0      2      0   100%
google/cloud/translate_v3beta1/types.py         17      0      4      0   100%
----------------------------------------------------------------------------------------
TOTAL                                          152     10     44      0    95%
Command coverage report --show-missing --fail-under=100 failed with exit code 2
Session cover failed.

Docs:

It looks like the symlink for changelog is wrong.
Delete docs/changelog.md and make a new symlink.

cd docs
rm changelog.md
ln -s ../CHANGELOG.md changelog.md

@leahecole leahecole merged commit e243f75 into master Jan 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

1 more reviewer

@busunkim96 busunkim96 busunkim96 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@leahecole @busunkim96 @googlebot @yoshi-kokoro