Fix template list discovery algorithm: missing continue #5270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the end of the first 'if' clause, where '<' is matched, insert a 'Start the next iteration of the loop.' Otherwise execution reaches the 'advance token' at the bottom of the loop. For example, in parsing: X < Y > The '>' would be consumed too early, and template list discovery gets the wrong answer. Fixes: gpuweb#5246
|
Previews, as seen when this build job started (d286ece): |
mehmetoguzderin
approved these changes
Jul 30, 2025
There was a problem hiding this comment.
LGTM, thank you very much for the PR! Also thank you very much @k2d222 for pointing this out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the end of the first 'if' clause, where '<' is matched, insert a 'Start the next iteration of the loop.'
Otherwise execution reaches the 'advance token' at the bottom of the loop.
For example, in parsing: X < Y >
The '>' would be consumed too early, and template list discovery gets the wrong answer.
Fixes: #5246