Fix flaky DefaultWorkerProcessBuilderIntegrationTest #34426
Merged
+5
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This comment has been minimized.
This comment has been minimized.
In the past, this test asserts the test class path includes current user home. This is true on Hetzner machines, because project directory is in user home (`/home/tcagent1/work/f63322e10dd6b396`), but not true on EC2 agents, because on EC2 agents the project directory is in `/mnt/tcagent1/work/f63322e10dd6b396`. [Example](https://ge.gradle.org/s/sncrks4ihxvey/tests/task/:core:isolatedProjectsIntegTest/details/org.gradle.process.internal.worker.DefaultWorkerProcessBuilderIntegrationTest/test%20classpath%20does%20not%20contain%20nonexistent%20entries?top-execution=1) This PR fixes this by getting correct gradle user home in integration context. Co-authored-by: Bo Zhang <[email protected]>
This comment has been minimized.
This comment has been minimized.
bot-gradle
force-pushed
the
bz/fix-flaky-DefaultWorkerProcessBuilderIntegrationTest
branch
from
a485e89 to
a3430f0
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
The following builds have passed: |
blindpirate
deleted the
bz/fix-flaky-DefaultWorkerProcessBuilderIntegrationTest
branch
|
@bot-gradle cherrypick to release |
bot-gradle
pushed a commit
that referenced
this pull request
Jul 29, 2025
|
I have cherry-picked to PR #34467. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the past, this test asserts the test class path includes current user home. This is true on Hetzner machines, because project directory is in user home (
/home/tcagent1/work/f63322e10dd6b396), but not true on EC2 agents, because on EC2 agents the project directory is in/mnt/tcagent1/work/f63322e10dd6b396.Example
This PR fixes this by getting correct gradle user home in integration context.