Skip to content

Azure: Fix time management field #107993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 22, 2025
Merged

Azure: Fix time management field #107993

merged 5 commits into from
Jul 22, 2025

Conversation

aangelisc
Copy link
Contributor

A bug was introduced in #99055 that sets the default mode for Log Analytics queries to builder. This is actually invalid for two reasons:

  1. It can break existing queries (it hasn't yet but in theory it could).
  2. It prevents switching the time management field between query and dashboard as query is disabled for the builder.

I've also added tests for this case.

Fixes #106555

@aangelisc aangelisc self-assigned this Jul 10, 2025
@aangelisc aangelisc requested a review from a team as a code owner July 10, 2025 20:23
@aangelisc aangelisc requested review from beejeebus and removed request for a team July 10, 2025 20:23
@aangelisc aangelisc requested a review from alyssajoyner July 10, 2025 20:23
@aangelisc aangelisc added datasource/Azure Azure Monitor Datasource backport v12.0.x Mark PR for automatic backport to v12.0.x labels Jul 10, 2025
@github-actions github-actions bot added this to the 12.1.x milestone Jul 10, 2025
@aangelisc aangelisc moved this from Incoming to Needs Review in Partner Datasources Jul 16, 2025
@aangelisc aangelisc merged commit a421f55 into main Jul 22, 2025
97 of 98 checks passed
@aangelisc aangelisc deleted the andreas/fix-time-selector branch July 22, 2025 15:47
@github-project-automation github-project-automation bot moved this from Needs Review to Done in Partner Datasources Jul 22, 2025
grafana-delivery-bot bot pushed a commit that referenced this pull request Jul 22, 2025
* Fix mode setting

* Update selector

* Add tests

* Fix condition

(cherry picked from commit a421f55)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend backport v12.0.x Mark PR for automatic backport to v12.0.x datasource/Azure Azure Monitor Datasource effort/small type/bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Azure: Unable to switch time-range mode
2 participants