Chore: Remove deprecated language_provider methods in prometheus package #108352
+85
−1,082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafana-prometheusRemovalsPromQlLanguageProvider/home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/index.d.ts default as PromQlLanguageProviderPromQlLanguageProvider.startTask /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts startTask: Promise;PromQlLanguageProvider.labelFetchTs /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts labelFetchTs: number;PromQlLanguageProvider.datasource /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts datasource: PrometheusDatasource;PromQlLanguageProvider.histogramMetrics /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts histogramMetrics: string[];PromQlLanguageProvider.metrics /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts metrics: string[];PromQlLanguageProvider.metricsMetadata /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts metricsMetadata?: PromMetricsMetadata;PromQlLanguageProvider.labelKeys /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts labelKeys: string[];PromQlLanguageProvider.request /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts request: (url: string, params?: {}, options?: Partial) => Promise;PromQlLanguageProvider.start /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts start: (timeRange?: TimeRange) => Promise;PromQlLanguageProvider.loadMetricsMetadata /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts loadMetricsMetadata(): Promise;PromQlLanguageProvider.getLabelKeys /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts getLabelKeys(): string[];PromQlLanguageProvider.getSeries /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts getSeries(timeRange: TimeRange, selector: string, withName?: boolean): Promise>;PromQlLanguageProvider.fetchLabelValues /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts fetchLabelValues: (range: TimeRange, key: string, limit?: string | number) => Promise;PromQlLanguageProvider.getLabelValues /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts getLabelValues(range: TimeRange, key: string): Promise;PromQlLanguageProvider.fetchLabels /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts fetchLabels: (timeRange: TimeRange, queries?: PromQuery[], limit?: string) => Promise;PromQlLanguageProvider.getSeriesValues /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts getSeriesValues: (timeRange: TimeRange, labelName: string, selector: string) => Promise;PromQlLanguageProvider.fetchSeriesValuesWithMatch /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts fetchSeriesValuesWithMatch: (timeRange: TimeRange, name: string, match?: string, requestId?: string, withLimit?: string | number) => Promise;PromQlLanguageProvider.getSeriesLabels /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts getSeriesLabels: (timeRange: TimeRange, selector: string, otherLabels: Label[]) => Promise;PromQlLanguageProvider.fetchLabelsWithMatch /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts fetchLabelsWithMatch: (timeRange: TimeRange, name: string, withName?: boolean, withLimit?: string | number) => Promise>;PromQlLanguageProvider.fetchSeriesLabels /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts fetchSeriesLabels: (timeRange: TimeRange, name: string, withName?: boolean, withLimit?: string | number) => Promise>;PromQlLanguageProvider.fetchSeriesLabelsMatch /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts fetchSeriesLabelsMatch: (timeRange: TimeRange, name: string, withLimit?: string | number) => Promise>;PromQlLanguageProvider.fetchSeries /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts fetchSeries: (timeRange: TimeRange, match: string) => Promise>>;PromQlLanguageProvider.fetchDefaultSeries /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts fetchDefaultSeries: (timeRange: TimeRange) => Promise<{}>;PromQlLanguageProvider.fetchSuggestions /home/runner/work/grafana/grafana/base/grafana-prometheus/dist/types/language_provider.d.ts fetchSuggestions: (timeRange?: TimeRange, queries?: PromQuery[], scopes?: Scope[], adhocFilters?: AdHocVariableFilter[], labelName?: string, limit?: number, requestId?: string) => Promise;
|
grafana-pr-automation
bot
added
the
levitate breaking change
grafana-pr-automation
bot
requested review from
a team and
Ukochka
and removed request for
a team
ivanahuckova
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
LGTM, nice cleanup! 👏 @itsmylife before merging, could you please confirm that you have checked that other apps outside of metrics drilldown are not using these methods and that it is okay to remove.
|
@ivanahuckova After talking to you I did another search without using github search. I found out there are some repositories that they use those methods. Github search never showed them to me. I'm gonna contact with those repo owners before merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Removing the deprecated
language_providermethods. This won't affectmetrics_drilldown.Context: https://raintank-corp.slack.com/archives/C0630AYC4SY/p1752247666446559