-
Notifications
You must be signed in to change notification settings - Fork 12.8k
LogLine: Add Explain in Assistant
option to explain single log lines
#108387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What do you think if we do the same thing in the panel and explose this everywhere? I can give it a try later today. |
Do you mean in the panel menu? |
Ah you already did it! 😆 . I saw this while having lunch and assumed Logs Drilldown. Amazing! |
@@ -81,6 +84,43 @@ export const LogLineMenu = ({ log, styles }: Props) => { | |||
} | |||
}, [log, onPinLine, onUnpinLine, pinned]); | |||
|
|||
const openAssistant = useCallback(async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be moved to https://github.com/grafana/grafana/blob/main/public/app/features/logs/components/panel/LogListContext.tsx, exposing both isAssistantAvailable
and openMainAssistant
through useLogListContext()
, allowing this to be used here and in the new Log Details: https://github.com/grafana/grafana/blob/main/public/app/features/logs/components/panel/LogLineDetailsHeader.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me! Feel free to decide whether to keep it in the Line menu, or also add it to details through context.
Sorry for the spam here. @matyax I moved to the context - that's cool. Would appreciate another look! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 👏
*What is this feature?
Adds an
Explain in Assistant
option to explain single log lines in each logs panel.Screen.Recording.2025-07-22.at.13.43.05.mov