Skip to content

Chore: add minimumReleaseAge to renovate config #108393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 21, 2025

Conversation

ashharrison90
Copy link
Contributor

What is this feature?

  • reenables automerging in renovate
  • adds a minimum release age of 7 days for non-grafana packages

Why do we need this feature?

  • keep deps up to date

Who is this feature for?

  • grafana devs

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@ashharrison90 ashharrison90 added this to the 12.1.x milestone Jul 21, 2025
@ashharrison90 ashharrison90 requested a review from a team July 21, 2025 13:56
@ashharrison90 ashharrison90 self-assigned this Jul 21, 2025
@ashharrison90 ashharrison90 removed the request for review from a team July 21, 2025 13:56
@ashharrison90 ashharrison90 requested a review from a team as a code owner July 21, 2025 13:56
@ashharrison90 ashharrison90 requested review from joshhunt, samsch and academo and removed request for a team July 21, 2025 13:56
@ashharrison90 ashharrison90 added type/chore dependencies Pull requests that update a dependency file no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Jul 21, 2025
matchCurrentVersion: "!/^0/",
matchUpdateTypes: ["patch"],
matchPackageNames: ["!/^@?storybook/", "!/^@locker/"],
matchPackageNames: ["!/^@?storybook/", "!/^@locker/", "!/^@grafana/"],
minimumReleaseAge: "7 days"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add minimumReleaseAge: "7 days" to all the other packageRules (like the one for react aria)? Or do they extend each other?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they don't extend each other, so yeah we'd need to add them to all. i can do that - is that something we want? i don't have a strong opinion either way, i'm more concerned about the automerging ones anyway 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is something we want - wait 7 days for all renovate PRs regardless of source.

Copy link
Contributor

@samsch samsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ashharrison90 ashharrison90 merged commit 5f3bcea into main Jul 21, 2025
87 of 88 checks passed
@ashharrison90 ashharrison90 deleted the ash/update-renovate-config branch July 21, 2025 15:18
@github-project-automation github-project-automation bot moved this from 🔍 In review to 🚀 Done in Grafana Frontend Platform Jul 21, 2025
macabu pushed a commit that referenced this pull request Jul 22, 2025
* add minimumReleaseAge to renovate config

* add minimumReleaseAge to non-grafana packages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/chore
Projects
Status: 🚀 Done
Development

Successfully merging this pull request may close these issues.

3 participants