-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Chore: add minimumReleaseAge
to renovate config
#108393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
.github/renovate.json5
Outdated
matchCurrentVersion: "!/^0/", | ||
matchUpdateTypes: ["patch"], | ||
matchPackageNames: ["!/^@?storybook/", "!/^@locker/"], | ||
matchPackageNames: ["!/^@?storybook/", "!/^@locker/", "!/^@grafana/"], | ||
minimumReleaseAge: "7 days" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to add minimumReleaseAge: "7 days"
to all the other packageRules (like the one for react aria)? Or do they extend each other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they don't extend each other, so yeah we'd need to add them to all. i can do that - is that something we want? i don't have a strong opinion either way, i'm more concerned about the automerging ones anyway 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is something we want - wait 7 days for all renovate PRs regardless of source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* add minimumReleaseAge to renovate config * add minimumReleaseAge to non-grafana packages
What is this feature?
Why do we need this feature?
Who is this feature for?
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: