Skip to content

update storage-api to only build index if it owns the namespace #108418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 23, 2025
Merged

update storage-api to only build index if it owns the namespace #108418

merged 4 commits into from
Jul 23, 2025
+73 −16

Conversation

gassiss
Copy link
Contributor

@gassiss gassiss commented Jul 21, 2025 •
edited
Loading

@gassiss gassiss marked this pull request as ready for review July 21, 2025 22:40
@gassiss gassiss requested a review from a team as a code owner July 21, 2025 22:40
@gassiss gassiss requested review from suntala and removed request for a team July 21, 2025 22:40
@github-actions github-actions bot added this to the 12.1.x milestone Jul 21, 2025
@mustafasencer mustafasencer added the no-changelog Skip including change in changelog/release notes label Jul 22, 2025
@mustafasencer mustafasencer force-pushed the unistore-search-shard-index branch from d876517 to cc1e49c Compare July 22, 2025 08:46
mustafasencer
mustafasencer approved these changes Jul 22, 2025
View reviewed changes
Copy link
Contributor

@mustafasencer mustafasencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I just rebased the changes with the ReplicationFactor support and used GetWithOptions instead of Get for the searchRingRead and searchOwnerRead.

@gassiss
Copy link
Contributor Author

gassiss commented Jul 23, 2025

/deploy-to-hg

@ephemeral-instances-bot
Copy link

  • Preparing your instance. A comment containing your instance's url will be added to this PR when the instance is ready.
  • Your instance will be ready in ~10 minutes. Follow the workflow progress
  • Slack channel: #proj-ephemeral-hg-instances
  • Building instance with unistore-search-shard-index oss branch and main enterprise branch. How to choose a branch

@ephemeral-instances-bot
Copy link

Error building instance: Contact #proj-ephemeral-hg-instances if it is not a compile error. Logs

@gassiss
Copy link
Contributor Author

gassiss commented Jul 23, 2025

/deploy-to-hg

@ephemeral-instances-bot
Copy link

  • Preparing your instance. A comment containing your instance's url will be added to this PR when the instance is ready.
  • Your instance will be ready in ~10 minutes. Follow the workflow progress
  • Slack channel: #proj-ephemeral-hg-instances
  • Building instance with unistore-search-shard-index oss branch and main enterprise branch. How to choose a branch

@ephemeral-instances-bot
Copy link

@gassiss gassiss merged commit 981fdb2 into main Jul 23, 2025
100 checks passed
@gassiss gassiss deleted the unistore-search-shard-index branch July 23, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mustafasencer mustafasencer mustafasencer approved these changes

@suntala suntala Awaiting requested review from suntala suntala is a code owner automatically assigned from grafana/grafana-search-and-storage

Assignees
No one assigned
Labels
area/backend no-changelog Skip including change in changelog/release notes
Projects
None yet
Milestone
12.1.x
Development

Successfully merging this pull request may close these issues.
2 participants
@gassiss @mustafasencer