Fix: plugin loader cache not matching on decoupled plugin paths #108529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackw
added
no-backport
github-project-automation
bot
moved this to 📬 Triage
in Plugins Platform / Grafana Community
jackw
changed the title
wbrowne
approved these changes
Jul 23, 2025
devenv/local_cdn/default.conf
Outdated
| @@ -19,6 +19,6 @@ server { | |||
| add_header 'Access-Control-Allow-Headers' '*' always; | |||
| add_header 'Access-Control-Allow-Credentials' 'true' always; | |||
|
|
|||
| rewrite ^/grafana-oss/11.4.0-pre/public(.*)$ $1 last; | |||
| rewrite ^/grafana/12.1.0-pre/public(.*)$ $1 last; | |||
There was a problem hiding this comment.
I guess it makes sense to keep this as the non OSS version from now on 👍
There was a problem hiding this comment.
Am I missing something or this functionality doesn't fully work in OSS version now?
There was a problem hiding this comment.
Actually maybe it doesn't make sense to change. Core plugins in OSS won't make use of this feature - but this change means OSS assets won't get loaded, right?
There was a problem hiding this comment.
I couldn't get anything to load whilst testing this without making this change but maybe I made a mistake somewhere down the road to getting this all running locally for this bug fix. I'll revert the -oss part. The version change is legit.
github-project-automation
bot
moved this from 📬 Triage
to 🔬 In review
in Plugins Platform / Grafana Community
academo
approved these changes
Jul 23, 2025
leventebalogh
approved these changes
Jul 24, 2025
github-project-automation
bot
moved this from 🔬 In review
to 🚀 Shipped
in Plugins Platform / Grafana Community
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR fixes an issue due to Decoupled core plugins now loading from different asset paths to regular plugins which prevented the loader cache (which stores information related to which version to append to the cache buster query param and loadingStrategy) from having any effect.
Why do we need this feature?
So decoupled plugins continue to load using the version as a cache buster and the correct loading strategy
Who is this feature for?
Everyone.
Which issue(s) does this PR fix?:
Fixes #107132
Special notes for your reviewer:
Please check that: