Skip to content

Plugins: Add grafana-iot-twinmaker-datasource to forward_settings_to_plugins #108560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2025

Conversation

chriscerie
Copy link
Contributor

@chriscerie chriscerie commented Jul 23, 2025

What is this feature?

Fixes issue where we get attempting to use an auth type that is not allowed: \"ec2_iam_role\". due to grafana-iot-twinmaker-datasource not getting forwarded AWS settings. It's not clear to me whether we still need to keep grafana-iot-twinmaker-app.

Which issue(s) does this PR fix?:

Fixes #108559

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@chriscerie chriscerie requested a review from torkelo as a code owner July 23, 2025 21:45
@github-actions github-actions bot added this to the 12.1.x milestone Jul 23, 2025
@chriscerie
Copy link
Contributor Author

Hi @iwysiu , I've removed -app based on this comment. Please let me know if we should add it back in. Thanks

@njvrzm njvrzm merged commit 15f291a into grafana:main Jul 28, 2025
86 of 89 checks passed
@chriscerie chriscerie deleted the fix-twinmaker2 branch July 28, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugins: TwinMaker not getting forwarded AWS settings
3 participants