Skip to content

Provisioning: Fix stage options for export #108585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 24, 2025

Conversation

MissingRoberto
Copy link
Contributor

What is this feature?

Fix the bug creating the stage writer only with the configured branch for export job.

Why do we need this feature?

We uncovered a bug in this other PR #108580. Basically, we always create the writer based on the configured branch and not to write on the target branch that may be passed for the job.

Who is this feature for?

Users of Git Sync / Provisioning.

How

  • Add ref option to stage options and use it to stage the writer with the right branch.
  • Fix the issue with ref in export worker.
  • Add unit tests for export stage options.

Which issue(s) does this PR fix?:

Fixes https://github.com/grafana/git-ui-sync-project/issues/377

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@MissingRoberto MissingRoberto requested a review from a team as a code owner July 24, 2025 11:31
@MissingRoberto MissingRoberto added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Jul 24, 2025
@MissingRoberto MissingRoberto requested review from konsalex and removed request for a team July 24, 2025 11:31
@MissingRoberto MissingRoberto self-assigned this Jul 24, 2025
@github-actions github-actions bot added this to the 12.1.x milestone Jul 24, 2025
@MissingRoberto MissingRoberto marked this pull request as draft July 24, 2025 11:31
@MissingRoberto MissingRoberto removed the request for review from konsalex July 24, 2025 11:31
@MissingRoberto MissingRoberto marked this pull request as ready for review July 24, 2025 11:37
@MissingRoberto MissingRoberto requested review from a team and stephaniehingtgen July 24, 2025 11:38
@stephaniehingtgen stephaniehingtgen enabled auto-merge (squash) July 24, 2025 16:33
@stephaniehingtgen stephaniehingtgen merged commit e9b9618 into main Jul 24, 2025
102 checks passed
@stephaniehingtgen stephaniehingtgen deleted the bugfix/staged-ref-option branch July 24, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants