Skip to content

Frontend: Move toEmit jest matchers to shared workspace #108610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Frontend: Move toEmit jest matchers to shared workspace #108610

wants to merge 6 commits into from
+137 −26

Conversation

jackw
Copy link
Contributor

@jackw jackw commented Jul 24, 2025

What is this feature?

This PR moves the toEmit jest matchers to a shared workspace to make it possible for decoupled plugins to use them whilst running their test scripts separately.

Why do we need this feature?

To make it easier for plugin devs to decouple plugins and to test their plugins.

Who is this feature for?

Plugin devs

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@jackw jackw self-assigned this Jul 24, 2025
@jackw jackw added area/frontend no-backport Skip backport of PR labels Jul 24, 2025
@jackw jackw requested review from a team as code owners July 24, 2025 15:23
@jackw jackw added the no-changelog Skip including change in changelog/release notes label Jul 24, 2025
@jackw jackw requested review from a team as code owners July 24, 2025 15:23
@jackw jackw requested review from joshhunt, samsch, beejeebus, bossinc, aangelisc, adamyeats, zoesyc, Ukochka and gabor and removed request for a team July 24, 2025 15:23
@github-actions github-actions bot added this to the 12.1.x milestone Jul 24, 2025
@github-actions github-actions bot added datasource/Azure Azure Monitor Datasource datasource/Zipkin datasource/grafana-pyroscope Grafana pyroscope datasource (previously Phlare) labels Jul 24, 2025
ivanahuckova
ivanahuckova approved these changes Jul 25, 2025
View reviewed changes
Copy link
Contributor

@ivanahuckova ivanahuckova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! The code looks good and also verified that it resolves Loki's toEmitValuesWith issues in test. LGTM 👏

@ivanahuckova ivanahuckova mentioned this pull request Jul 25, 2025
Open
@jackw jackw force-pushed the jackw/move-to-emit-helpers branch from 8638e4b to 36c7a46 Compare July 25, 2025 13:59
ivanahuckova
ivanahuckova approved these changes Jul 25, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanahuckova ivanahuckova ivanahuckova approved these changes

@joshhunt joshhunt Awaiting requested review from joshhunt joshhunt is a code owner automatically assigned from grafana/grafana-frontend-platform

@samsch samsch Awaiting requested review from samsch samsch is a code owner automatically assigned from grafana/grafana-frontend-platform

@beejeebus beejeebus Awaiting requested review from beejeebus beejeebus is a code owner automatically assigned from grafana/partner-datasources

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@aangelisc aangelisc Awaiting requested review from aangelisc aangelisc is a code owner automatically assigned from grafana/partner-datasources

@adamyeats adamyeats Awaiting requested review from adamyeats adamyeats is a code owner automatically assigned from grafana/partner-datasources

@zoesyc zoesyc Awaiting requested review from zoesyc zoesyc is a code owner automatically assigned from grafana/partner-datasources

@Ukochka Ukochka Awaiting requested review from Ukochka Ukochka is a code owner automatically assigned from grafana/plugins-platform-frontend

@gabor gabor Awaiting requested review from gabor gabor is a code owner automatically assigned from grafana/frontend-ops

Assignees

@jackw jackw

Labels
area/frontend datasource/Azure Azure Monitor Datasource datasource/GoogleCloudMonitoring datasource/grafana-pyroscope Grafana pyroscope datasource (previously Phlare) datasource/Jaeger datasource/MySQL datasource/Parca Parca datasource datasource/Postgres datasource/Tempo datasource/Zipkin no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
Grafana Frontend Platform
Status: 🔍 In review
Milestone
12.1.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackw @ivanahuckova