Skip to content

Table: Reorder cell types selector #108629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Table: Reorder cell types selector #108629

wants to merge 6 commits into from
+67 −50

Conversation

fastfrwrd
Copy link
Contributor

@fastfrwrd fastfrwrd commented Jul 24, 2025 •
edited
Loading

We noticed when updating the Table docs for the TableNG rollout that the order of the Cell Type selector in both TableNG and Table could use some more thought.

  • ordered the cell types in a more thoughtful manner in both TableNG and TableRT.
    • kinda just... stuck Pills in a place that makes sense to me?
  • in TableNG, localized cell type names.
  • in TableNG, replaced deprecated Select with Combobox for TableCellOptionEditor.
  • updated docs to reflect new order.

TODO

  • I want to add an e2e tests which exercises changing the cell type to ensure that the cell type selector works as expected.

@fastfrwrd fastfrwrd requested a review from a team as a code owner July 24, 2025 18:04
@fastfrwrd fastfrwrd requested review from leeoniya, jesdavpet and adela-almasan and removed request for a team July 24, 2025 18:04
@github-actions github-actions bot added this to the 12.1.x milestone Jul 24, 2025
@fastfrwrd fastfrwrd added the no-changelog Skip including change in changelog/release notes label Jul 24, 2025
@fastfrwrd fastfrwrd requested a review from grafanabot as a code owner July 24, 2025 20:21
@fastfrwrd fastfrwrd requested a review from imatwawana as a code owner July 25, 2025 14:24
@github-actions github-actions bot added the type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project label Jul 25, 2025
@github-actions GitHub Actions
Copy link
Contributor

💻 Deploy preview available:

imatwawana
imatwawana approved these changes Jul 25, 2025
View reviewed changes
Copy link
Collaborator

@imatwawana imatwawana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fastfrwrd fastfrwrd changed the title Table: Reorder cell types selector, add Alpha denotation in TableNG for Pills Table: Reorder cell types selector Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imatwawana imatwawana imatwawana approved these changes

@leeoniya leeoniya Awaiting requested review from leeoniya leeoniya is a code owner automatically assigned from grafana/dataviz-squad

@jesdavpet jesdavpet Awaiting requested review from jesdavpet jesdavpet is a code owner automatically assigned from grafana/dataviz-squad

@adela-almasan adela-almasan Awaiting requested review from adela-almasan adela-almasan is a code owner automatically assigned from grafana/dataviz-squad

@grafanabot grafanabot Awaiting requested review from grafanabot grafanabot is a code owner

Assignees
No one assigned
Labels
area/frontend area/panel/table no-changelog Skip including change in changelog/release notes type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
None yet
Milestone
12.1.x
Development

Successfully merging this pull request may close these issues.
2 participants
@fastfrwrd @imatwawana