Skip to content

Conversation

jtvdez
Copy link
Contributor

@jtvdez jtvdez commented Jul 29, 2025

What is this feature?

Adds additional info to custom branding docs about the login_logo config option (such as size and file type recommendations and how to reference locally stored images as the logo).

Why do we need this feature?

There have been several support escalations regarding these, therefore they would benefit from additional clarification.

Who is this feature for?

All users of the custom branding docs

Which issue(s) does this PR fix?:

Fixes https://github.com/grafana/support-escalations/issues/17573, https://github.com/grafana/support-escalations/issues/13589

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@jtvdez jtvdez self-assigned this Jul 29, 2025
@jtvdez jtvdez added type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project no-changelog Skip including change in changelog/release notes backport v11.5.x Backport to branch v11.5.x backport v11.6.x Mark PR for automatic backport to v11.6.x backport v12.0.x Mark PR for automatic backport to v12.0.x backport v12.1.x Mark PR for automatic backport to v12.1.x labels Jul 29, 2025
Copy link
Contributor

github-actions bot commented Jul 29, 2025

💻 Deploy preview deleted.

@jtvdez
Copy link
Contributor Author

jtvdez commented Aug 1, 2025

@Pawel-Kr @jasuade I've opened this in relation to the support requests in the description - does this information look correct to you both?

@jtvdez jtvdez requested review from jasuade and Pawel-Kr August 1, 2025 17:32
@jasuade
Copy link
Contributor

jasuade commented Aug 3, 2025

Thank you @jtvdez its perfect!

Copy link
Contributor

@jasuade jasuade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtvdez jtvdez marked this pull request as ready for review August 4, 2025 20:57
@jtvdez jtvdez requested a review from irenerl24 as a code owner August 4, 2025 20:57
@jtvdez jtvdez merged commit 5bd6d24 into main Aug 5, 2025
135 of 137 checks passed
@jtvdez jtvdez deleted the docs/update-custom-branding branch August 5, 2025 13:33
grafana-delivery-bot bot pushed a commit that referenced this pull request Aug 5, 2025
grafana-delivery-bot bot pushed a commit that referenced this pull request Aug 5, 2025
grafana-delivery-bot bot pushed a commit that referenced this pull request Aug 5, 2025
grafana-delivery-bot bot pushed a commit that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v11.5.x Backport to branch v11.5.x backport v11.6.x Mark PR for automatic backport to v11.6.x backport v12.0.x Mark PR for automatic backport to v12.0.x backport v12.1.x Mark PR for automatic backport to v12.1.x no-changelog Skip including change in changelog/release notes type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants