-
Notifications
You must be signed in to change notification settings - Fork 12.9k
docs: Adding clarification to branding docs #108879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💻 Deploy preview deleted. |
Thank you @jtvdez its perfect! |
jasuade
approved these changes
Aug 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
irenerl24
approved these changes
Aug 5, 2025
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Aug 5, 2025
(cherry picked from commit 5bd6d24)
3 tasks
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Aug 5, 2025
(cherry picked from commit 5bd6d24)
3 tasks
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Aug 5, 2025
(cherry picked from commit 5bd6d24)
3 tasks
grafana-delivery-bot bot
pushed a commit
that referenced
this pull request
Aug 5, 2025
(cherry picked from commit 5bd6d24)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport v11.5.x
Backport to branch v11.5.x
backport v11.6.x
Mark PR for automatic backport to v11.6.x
backport v12.0.x
Mark PR for automatic backport to v12.0.x
backport v12.1.x
Mark PR for automatic backport to v12.1.x
no-changelog
Skip including change in changelog/release notes
type/docs
Flags the technical writing team for documentation support; auto adds to org-wide docs project
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Adds additional info to custom branding docs about the
login_logo
config option (such as size and file type recommendations and how to reference locally stored images as the logo).Why do we need this feature?
There have been several support escalations regarding these, therefore they would benefit from additional clarification.
Who is this feature for?
All users of the custom branding docs
Which issue(s) does this PR fix?:
Fixes https://github.com/grafana/support-escalations/issues/17573, https://github.com/grafana/support-escalations/issues/13589
Special notes for your reviewer:
Please check that: