Custom variable: support newline separated options #1191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where custom variables with newline-separated options were not properly parsed. The fix modifies the regex pattern to optionally match newlines at the beginning of option strings.
- Updates regex pattern to handle optional newlines in custom variable parsing
- Adds comprehensive test coverage for newline-separated options
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CustomVariable.tsx | Modified regex pattern to optionally match newlines at the start of option strings |
| CustomVariable.test.ts | Added test case to verify newline-separated options are parsed correctly |
Co-authored-by: Copilot <[email protected]>
ivanortegaalba
approved these changes
Jul 23, 2025
ivanortegaalba
added
patch
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was pointed out (as a bug) that custom variable does not properly recognize options separated with new line, like so:
Seems easy enough to fix