Skip to content

tweaks on save() taking column option #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 12, 2025
Merged

tweaks on save() taking column option #3136

merged 1 commit into from
Aug 12, 2025
+102 −93

Conversation

adumesny
Copy link
Member

Description

Checklist

  • Created tests which fail without the change (if possible)
  • All tests passing (yarn test)
  • Extended the README / documentation, if necessary

@adumesny
tweaks on save() takking column option
72949ee 
* more fix gridstack#2493
* engine save tweaks to hsow it gets column count (uses actual subgrid column and don't use _layouts if same as current)
* also reverted back to not save w/h:1 as people already workaround this if they need to and much less data by default.
@adumesny adumesny merged commit 1a51953 into gridstack:master Aug 12, 2025
@adumesny adumesny changed the title tweaks on save() takking column option tweaks on save() taking column option Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"grid.save()" returns wrong grid representation (nested and changed column count)
1 participant
@adumesny