Merged
Conversation
First cut. I assume there will be some bikeshedding for the new field names.
Member
|
CC @zhangkun83 . You may want to tweak Attribute.Keys names in the Java section at the end. |
ejona86
approved these changes
Oct 24, 2019
zhangkun83
reviewed
Oct 24, 2019
markdroth
reviewed
Oct 24, 2019
apolcyn
reviewed
Oct 25, 2019
Add groups link, implemented in C, link to C PR.
Member
Author
|
@markdroth PTAL |
markdroth
approved these changes
Oct 25, 2019
Member
Author
|
This PR will wait until November 8 for community feedback, in accordance with the documented gRFC process. |
a11r
approved these changes
Nov 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Abstract
Modify the method for enabling gRPCLB to not require any special handling in core, allowing for stabilization of the gRPCLB protocol and load balancing policy.
@ejona86 @markdroth - Please also provide implementation steps for C/Java if appropriate. Thanks!