Fixing port & host name, should fix #101, Fixing/chaning resources implementation #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR refactors Terraform MCP server resources and renames HTTP transport configuration flags/env variables to fix #101.
- Adds two new resources: Terraform Style Guide and Module Development Guide endpoints.
- Renames flags and environment variables from
host/port/MODEtotransport-host/transport-port/TRANSPORT_MODE. - Updates e2e tests and documentation to use the new names.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/hashicorp/tfregistry/resources.go | Implements style guide and module dev guide resources |
| e2e/e2e_test.go | Updates Docker run flags for HTTP transport in end-to-end tests |
| cmd/terraform-mcp-server/main.go | Renames flag retrieval and log messages |
| cmd/terraform-mcp-server/init.go | Updates CLI flags for transport-host/transport-port |
| README.md | Updates environment variable names and CLI usage examples |
Comments suppressed due to low confidence (3)
cmd/terraform-mcp-server/main.go:68
- The error message refers to "streamableHTTP port" while the flag is named --transport-port. Update the log text to use "transport port" for consistency.
stdlog.Fatal("Failed to get streamableHTTP port:", err)
e2e/e2e_test.go:22
- The test suite doesn’t validate the new /terraform/style-guide and /terraform/module-development endpoints. Add end-to-end tests for those routes to ensure correct behavior.
func TestE2E(t *testing.T) {
pkg/hashicorp/tfregistry/resources.go:18
- The original provider resource registrations were removed, which disables the official and partner provider endpoints. Consider re-adding or migrating them to ensure existing provider functionality remains available.
func RegisterResources(hcServer *server.MCPServer, registryClient *http.Client, logger *log.Logger) {
Comment on lines
+82
to
101
| for _, u := range urls { | ||
| resp, err := httpClient.Get(u.URL) | ||
| if err != nil { | ||
| return nil, logAndReturnError(logger, fmt.Sprintf("Provider Resource: error with provider template handler %s/%s provider version %s details", namespace, name, versionNumber), err) | ||
| return nil, logAndReturnError(logger, fmt.Sprintf("Error fetching %s markdown", u.Name), err) | ||
| } | ||
| resourceContents[i] = mcp.TextResourceContents{ | ||
| MIMEType: "text/markdown", | ||
| URI: providerVersionUri, | ||
| Text: fmt.Sprintf("# %s Provider \n\n %s", provider["name"], providerDocs), | ||
| if resp.StatusCode != http.StatusOK { | ||
| resp.Body.Close() | ||
| return nil, logAndReturnError(logger, fmt.Sprintf("Non-200 response fetching %s markdown", u.Name), fmt.Errorf("status: %s", resp.Status)) | ||
| } | ||
| body, err := io.ReadAll(resp.Body) | ||
| resp.Body.Close() | ||
| if err != nil { | ||
| return nil, logAndReturnError(logger, fmt.Sprintf("Error reading %s markdown", u.Name), err) | ||
| } | ||
| contents = append(contents, mcp.TextResourceContents{ | ||
| MIMEType: "text/markdown", | ||
| URI: fmt.Sprintf("%s/%s", resourceURI, u.Name), | ||
| Text: string(body), | ||
| }) | ||
| } |
There was a problem hiding this comment.
Fetching each markdown file sequentially can increase latency. Consider performing HTTP GETs in parallel or caching responses to improve performance.
Copilot uses AI. Check for mistakes.
mukeshjc
approved these changes
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.