Update Dropzone.js to 5.9.2 #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greyli
reviewed
May 16, 2021
flask_dropzone/__init__.py
Outdated
| @@ -26,7 +26,7 @@ | |||
| class _Dropzone(object): | |||
|
|
|||
| @staticmethod | |||
| def load(js_url='', css_url='', version='5.2.0'): | |||
| def load(js_url='', css_url='', version='latest'): | |||
There was a problem hiding this comment.
I think it's may not a good idea to use latest as the default value since we provide built-in resources with a fixed version. We have to sync the local resource inside the extension to the latest version. Otherwise, the user may meet inconsistent results when disable/enable the DROPZONE_SERVE_LOCAL config.
There was a problem hiding this comment.
Yes, I also think of this after submit the PR, I will drop the code relevant.
greyli
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes of three parts:
Supplement #49