Skip to content

fix: import Markup from markupsafe instead of flask #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix: import Markup from markupsafe instead of flask #63

merged 1 commit into from
Jan 16, 2024

Conversation

yuxiaoy1
Copy link
Collaborator

  • fix Markup imports for error below
  • format code with Ruff
File "/Users/yuxiaoy/Developer/python/source-code/flask-dropzone/examples/venv/lib/python3.12/site-packages/flask_dropzone/__init__.py", line 11, in <module>
    from flask import Blueprint, current_app, url_for, Markup, render_template_string
ImportError: cannot import name 'Markup' from 'flask'

@yuxiaoy1 yuxiaoy1 merged commit eeded3b into helloflask:master Jan 16, 2024
@yuxiaoy1 yuxiaoy1 deleted the fix/markup-error branch January 16, 2024 13:33
@yuxiaoy1 yuxiaoy1 mentioned this pull request Jan 31, 2024
Closed
@dcb-imvaria
Copy link

Is there a timeline for creating a new release with this fix? Currently without specifying a 2.X flask version, flask-dropzone fails to run.

@greyli greyli mentioned this pull request Feb 18, 2024
Closed
@greyli
Copy link
Member

greyli commented Feb 18, 2024

@dcb-imvaria 2.0.0 version released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yuxiaoy1 @dcb-imvaria @greyli