perf(PostCategory/PostTag): add binary relation index for performance #5605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to testgit clone -b perf/binary-relation-index https://github.com/D-Sketon/hexo.git
cd hexo
npm install
npm test |
Pull Request Test Coverage Report for Build 13067175174Details
💛 - Coveralls |
SukkaW
previously approved these changes
Jan 10, 2025
renbaoshuo
previously approved these changes
Jan 10, 2025
Member
Author
|
No hook will be triggered during the warehouse import process, so we must manually trigger the saveHook after loading the db.json. |
Signed-off-by: D-Sketon <[email protected]>
SukkaW
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it do?
#5604
To improve performance, I introduced indexes for binary relations to improve lookup speeds.
The overhead from
findandfindOneis now largely invisible on the flamegraph:Screenshots
8x many-posts
before
after
1x many-posts
before
after
This is a huge boost for blogs with a super large number of posts, but hopefully this won't have any side effects on the generation of the site.
Pull request tasks