Add network monitor during app start #5581
Merged
+572
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpetrovski
force-pushed
the
bugfix/network-check-on-start
branch
from
7ae9c4e to
c5f5b97
Compare
TimoPtr
reviewed
Jul 23, 2025
app/src/main/kotlin/io/homeassistant/companion/android/launch/LaunchActivity.kt
Show resolved
Hide resolved
app/src/main/kotlin/io/homeassistant/companion/android/launch/LaunchPresenterBase.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/io/homeassistant/companion/android/launch/LaunchPresenterBase.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/io/homeassistant/companion/android/launch/LaunchPresenterBase.kt
Outdated
Show resolved
Hide resolved
app/src/main/kotlin/io/homeassistant/companion/android/launch/LaunchPresenterBase.kt
Outdated
Show resolved
Hide resolved
common/src/main/kotlin/io/homeassistant/companion/android/common/data/network/WifiHelper.kt
Show resolved
Hide resolved
...otlin/io/homeassistant/companion/android/common/data/network/NetworkStatusMonitorImplTest.kt
Outdated
Show resolved
Hide resolved
...otlin/io/homeassistant/companion/android/common/data/network/NetworkStatusMonitorImplTest.kt
Outdated
Show resolved
Hide resolved
...otlin/io/homeassistant/companion/android/common/data/network/NetworkStatusMonitorImplTest.kt
Show resolved
Hide resolved
fpetrovski
force-pushed
the
bugfix/network-check-on-start
branch
from
18213e2 to
5d38c73
Compare
TimoPtr
reviewed
Jul 30, 2025
app/src/full/kotlin/io/homeassistant/companion/android/launch/LaunchPresenterImpl.kt
Outdated
Show resolved
Hide resolved
TimoPtr
reviewed
Jul 30, 2025
app/src/main/kotlin/io/homeassistant/companion/android/launch/LaunchPresenter.kt
Outdated
Show resolved
Hide resolved
TimoPtr
reviewed
Jul 30, 2025
app/src/minimal/kotlin/io/homeassistant/companion/android/launch/LaunchPresenterImpl.kt
Outdated
Show resolved
Hide resolved
TimoPtr
reviewed
Jul 30, 2025
.../kotlin/io/homeassistant/companion/android/common/data/network/NetworkCapabilitiesChecker.kt
Outdated
Show resolved
Hide resolved
TimoPtr
reviewed
Jul 30, 2025
common/src/main/kotlin/io/homeassistant/companion/android/di/NetworkModule.kt
Outdated
Show resolved
Hide resolved
jpelgrom
reviewed
Jul 30, 2025
app/src/full/kotlin/io/homeassistant/companion/android/launch/LaunchPresenterImpl.kt
Show resolved
Hide resolved
app/src/main/kotlin/io/homeassistant/companion/android/launch/LaunchPresenter.kt
Outdated
Show resolved
Hide resolved
TimoPtr
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change adds a network monitor on app start, before launching the WebView. With this addition the launch activity presenter can observe the network status and react on 4 different states:
READY_LOCAL,
READY_REMOTE,
CONNECTING,
UNAVAILABLE,
If there is no network available an alert dialog is displayed, notifying the user to check their connection.
This change fixes #5524
Checklist
Screenshots
The message used in the alert dialog is: Network unavailable, please enable your connection
Any other notes