Skip to content

Document MCF as a supported unit #40281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open

Document MCF as a supported unit #40281

wants to merge 1 commit into from

Conversation

pioto
Copy link

@pioto pioto commented Aug 5, 2025 •
edited
Loading

Proposed change

As added on home-assistant/core#150015, I'm proposing adding support for MCF as a valid unit for volume / gas, similar to CCF which was added here on #25292

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@pioto pioto requested a review from a team as a code owner August 5, 2025 02:08
@home-assistant home-assistant bot added current This PR goes into the current branch has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Aug 5, 2025
@home-assistant
Copy link

home-assistant bot commented Aug 5, 2025

It seems that this PR is targeted against an incorrect branch since it has a parent PR on one of our codebases. Documentation that needs to be updated for an upcoming release should target the next branch. Please change the target branch of this PR to next and rebase if needed.

@netlify Netlify
Copy link

netlify bot commented Aug 5, 2025 •
edited
Loading

✅ Deploy Preview for home-assistant-docs ready!

Name Link
🔨 Latest commit 500618b
🔍 Latest deploy log https://app.netlify.com/projects/home-assistant-docs/deploys/6891fcb3bcf4420009ba79a3
😎 Deploy Preview https://deploy-preview-40281--home-assistant-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

This was referenced Aug 5, 2025
Open
Open
@c0ffeeca7
Copy link
Contributor

Why is home-assistant/core#84029 linked as parent PR? shouldn't it be home-assistant/core#150015?

@c0ffeeca7
Copy link
Contributor

As this PR is related to a new feature added to core, please rebase this against the nextbranch.

@c0ffeeca7 c0ffeeca7 marked this pull request as draft August 5, 2025 07:03
@c0ffeeca7
Copy link
Contributor

I'm drafting this PR, as changes are needed. Please undraft it, once the changes have been implemented and the PR is ready for review again.

@pioto
Copy link
Author

pioto commented Aug 5, 2025

Why is home-assistant/core#84029 linked as parent PR? shouldn't it be home-assistant/core#150015?

Whoops, fixed (too many open tabs!)

@pioto pioto changed the base branch from current to next August 5, 2025 12:44
@home-assistant home-assistant bot removed current This PR goes into the current branch needs-rebase The PR has been branched of the wrong base branch or targets an incorrect target branch labels Aug 5, 2025
@home-assistant home-assistant bot added the next This PR goes into the next branch label Aug 5, 2025
@pioto pioto mentioned this pull request Aug 5, 2025
Open
9 tasks
@pioto pioto marked this pull request as ready for review August 5, 2025 23:53
c0ffeeca7
c0ffeeca7 approved these changes Aug 7, 2025
View reviewed changes
Copy link
Contributor

@c0ffeeca7 c0ffeeca7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pioto 👍

@c0ffeeca7 c0ffeeca7 added the awaits-parent Awaits the merge of an parent PR label Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0ffeeca7 c0ffeeca7 c0ffeeca7 approved these changes

Assignees
No one assigned
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in another repo in-progress This PR/Issue is currently being worked on next This PR goes into the next branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pioto @c0ffeeca7