Skip to content

allowing for extra properties in edi file declaration #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 29, 2023
Merged

allowing for extra properties in edi file declaration #207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5ec7f7e
allowing for extra properties in edi file declaration
jose-sherpa Jun 29, 2023
95b6d4b
changing to explicitly allow _comment property
jose-sherpa Jun 29, 2023
e771271
adding _comment to test files
jose-sherpa Jun 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion extensions/omniv21/samples/edi/1_canadapost_edi_214.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
"child_segments": [
{
"name": "GS",
"_comment": "functional group",
"child_segments": [
{
"name": "scanInfo", "type": "segment_group", "min": 0, "max": -1, "is_target": true,
Expand All @@ -26,7 +27,7 @@
{
"name": "N4",
"elements": [
{ "name": "cityName", "index": 1 },
{ "name": "cityName", "index": 1, "_comment": "E19" },
{ "name": "provinceCode", "index": 2 },
{ "name": "postalCode", "index": 3 },
{ "name": "countryCode", "index": 4 }
Expand Down
3 changes: 2 additions & 1 deletion extensions/omniv21/samples/edi/2_ups_edi_210.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
"child_segments": [
{
"name": "GS",
"_comment": "functional group",
"child_segments": [
{
"name": "invoiceInfo", "type": "segment_group", "min": 0, "max": -1, "is_target": true,
Expand Down Expand Up @@ -74,7 +75,7 @@
"elements": [
{ "name": "refIdQualifier_N901", "index": 1 },
{ "name": "refId_N902", "index": 2, "default": "" },
{ "name": "date", "index": 4, "default": "" },
{ "name": "date", "index": 4, "default": "", "_comment": "YYYYMMDD"},
{ "name": "product_code_C04004", "index": 7, "component_index": 4, "default": "" }
]
},
Expand Down
9 changes: 6 additions & 3 deletions extensions/omniv21/validation/ediFileDeclaration.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions extensions/omniv21/validation/ediFileDeclaration.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@
"index": { "type": "integer", "minimum": 1 },
"component_index": { "type": "integer", "minimum": 1 },
"empty_if_missing": { "type": "boolean","$comment": "deprecated, use 'default'" },
"default": { "type": "string" }
"default": { "type": "string" },
"_comment": { "$ref": "#/definitions/value_comment" }
},
"required": [ "name", "index" ],
"additionalProperties": false
Expand All @@ -53,10 +54,12 @@
"items": {
"$ref": "#/definitions/segment_declaration_type"
}
}
},
"_comment": { "$ref": "#/definitions/value_comment" }
},
"required": [ "name" ],
"additionalProperties": false
}
},
"value_comment": { "type": "string" }
}
}