Skip to content

Conversation

evaniainbrooks
Copy link
Contributor

issue #8029

@enebo
Copy link
Member

enebo commented Jan 1, 2024

@evaniainbrooks Can you apply this PR against the 9.5-dev branch? 9.4 is 3.1.x Ruby and 9.5 will be 3.3. Also if this is new 3.3 behavior you should add a version guard like:

  ruby_version_is "3.2" do
    it "raises a TypeError if passed a Hash with an unknown key" do
      -> { Struct.new(:animal, { name: 'chris' }) }.should raise_error(TypeError)
    end
  end

It also accepts a range so you can do things like ..3.2. At some future point when this becomes our main branch we get our spec changes merged back to ruby/spec so this will save that project some bother of having to add the version guard. At any time if you feel like adding new specs you can also PR directly to ruby/spec but it will still get there from our PRs at some point.

@evaniainbrooks evaniainbrooks force-pushed the 8029-freeze-queue-type-error branch from 6e90217 to 02ee063 Compare January 2, 2024 08:30
@evaniainbrooks evaniainbrooks changed the base branch from master to 9.5-dev January 2, 2024 08:30
@enebo enebo added this to the JRuby 9.5.0.0 milestone Jan 2, 2024
@enebo enebo merged commit 59bd791 into jruby:9.5-dev Jan 2, 2024
@enebo
Copy link
Member

enebo commented Jan 2, 2024

Looks like we have some weird problems on 9.5-dev still but it is relatively new. Thanks for the fix. I marked this item as finished in #8029.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants